Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ondrej Oprala <ooprala@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH 18/18] un-nest enum pvk
Date: Wed, 09 Oct 2013 17:18:00 -0000	[thread overview]
Message-ID: <1381339053-14519-19-git-send-email-ooprala@redhat.com> (raw)
In-Reply-To: <1381339053-14519-1-git-send-email-ooprala@redhat.com>

From: Tom Tromey <tromey@redhat.com>

 * prologue-value.h (pvk) : Unbundle it from struct prologue_value.
---
 gdb/ChangeLog        |  4 ++++
 gdb/prologue-value.h | 44 +++++++++++++++++++++++---------------------
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 802cc88..ed77894 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -17,6 +17,10 @@
 
 2013-10-09  Tom Tromey  <tromey@redhat.com>
 
+ * prologue-value.h (pvk) : Unbundle it from struct prologue_value.
+
+2013-10-09  Tom Tromey  <tromey@redhat.com>
+
  * gdbarch.c (byte_order) : Change type.
  (byte_order_for_code) : Likewise.
  (gdbarch_byte_order) : Change type of the return value.
diff --git a/gdb/prologue-value.h b/gdb/prologue-value.h
index b8ed813..af7728e 100644
--- a/gdb/prologue-value.h
+++ b/gdb/prologue-value.h
@@ -19,6 +19,28 @@
 #ifndef PROLOGUE_VALUE_H
 #define PROLOGUE_VALUE_H
 
+/* What sort of value is this?  This determines the interpretation
+   of subsequent fields.  */
+enum pvk {
+
+  /* We don't know anything about the value.  This is also used for
+     values we could have kept track of, when doing so would have
+     been too complex and we don't want to bother.  The bottom of
+     our lattice.  */
+  pvk_unknown,
+
+  /* A known constant.  K is its value.  */
+  pvk_constant,
+
+  /* The value that register REG originally had *UPON ENTRY TO THE
+     FUNCTION*, plus K.  If K is zero, this means, obviously, just
+     the value REG had upon entry to the function.  REG is a GDB
+     register number.  Before we start interpreting, we initialize
+     every register R to { pvk_register, R, 0 }.  */
+  pvk_register,
+
+};
+
 /* When we analyze a prologue, we're really doing 'abstract
    interpretation' or 'pseudo-evaluation': running the function's code
    in simulation, but using conservative approximations of the values
@@ -118,27 +140,7 @@
 
 struct prologue_value {
 
-  /* What sort of value is this?  This determines the interpretation
-     of subsequent fields.  */
-  enum {
-
-    /* We don't know anything about the value.  This is also used for
-       values we could have kept track of, when doing so would have
-       been too complex and we don't want to bother.  The bottom of
-       our lattice.  */
-    pvk_unknown,
-
-    /* A known constant.  K is its value.  */
-    pvk_constant,
-
-    /* The value that register REG originally had *UPON ENTRY TO THE
-       FUNCTION*, plus K.  If K is zero, this means, obviously, just
-       the value REG had upon entry to the function.  REG is a GDB
-       register number.  Before we start interpreting, we initialize
-       every register R to { pvk_register, R, 0 }.  */
-    pvk_register,
-
-  } kind;
+  enum pvk kind;
 
   /* The meanings of the following fields depend on 'kind'; see the
      comments for the specific 'kind' values.  */
-- 
1.8.3.1


  parent reply	other threads:[~2013-10-09 17:18 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 17:17 [PATCH 00/18] -Wc++-compat patches Ondrej Oprala
2013-10-09 17:17 ` [PATCH 02/18] poison "new" Ondrej Oprala
2013-10-10 12:23   ` Pedro Alves
2013-10-10 19:15   ` Jan Kratochvil
2013-10-09 17:17 ` [PATCH 03/18] poison "this" Ondrej Oprala
2013-10-09 17:25   ` Tom Tromey
2013-10-10 12:25   ` Pedro Alves
2013-10-09 17:17 ` [PATCH 01/18] poison "class" Ondrej Oprala
2013-10-09 21:45   ` Stan Shebs
2013-10-20 19:13   ` Mark Kettenis
2013-10-24 17:57     ` Joel Brobecker
2013-10-24 18:21       ` Stan Shebs
2013-10-09 17:18 ` [PATCH 13/18] poison "typename" Ondrej Oprala
2013-10-13 17:24   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 09/18] poison "namespace" Ondrej Oprala
2013-10-13 17:18   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 16/18] fix up gdbtypes.h Ondrej Oprala
2013-10-13 17:32   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 14/18] poison "using" Ondrej Oprala
2013-10-13 17:25   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 11/18] poison "template" Ondrej Oprala
2013-10-13 17:21   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 12/18] poison "try" Ondrej Oprala
2013-10-13 17:22   ` Jan Kratochvil
2013-10-09 17:18 ` Ondrej Oprala [this message]
2013-10-13 17:37   ` [PATCH 18/18] un-nest enum pvk Jan Kratochvil
2013-10-09 17:18 ` [PATCH 06/18] poison "delete" Ondrej Oprala
2013-10-13 16:47   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 17/18] fix gdbarch buglet Ondrej Oprala
2013-10-13 17:35   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 10/18] poison "operator" Ondrej Oprala
2013-10-13 17:20   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 04/18] poison "public" Ondrej Oprala
2013-10-13 16:39   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 15/18] fix up vec Ondrej Oprala
2013-10-13 17:29   ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 07/18] poison "explicit" Ondrej Oprala
2013-10-13 16:58   ` Jan Kratochvil
2013-10-09 17:53 ` [PATCH 08/18] poison "mutable" Ondrej Oprala
2013-10-13 17:00   ` Jan Kratochvil
2013-10-13 17:16     ` Jan Kratochvil
2013-10-09 18:09 ` [PATCH 05/18] poison "private" Ondrej Oprala
2013-10-13 16:45   ` Jan Kratochvil
2013-10-14  8:49   ` Pedro Alves
2013-10-14 15:36     ` Tom Tromey
2013-10-14 16:19       ` Pedro Alves
2013-10-09 18:56 ` [PATCH 00/18] -Wc++-compat patches Tom Tromey
2013-10-09 19:43   ` Ondrej Oprala
2013-10-21 15:37 [PATCH 00/18] -Wc++-compat patches v2.0 Ondrej Oprala
2013-10-21 15:37 ` [PATCH 18/18] un-nest enum pvk Ondrej Oprala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381339053-14519-19-git-send-email-ooprala@redhat.com \
    --to=ooprala@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox