Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix calling gcore when gdb is not in $PATH.
Date: Fri, 11 Oct 2013 14:31:00 -0000	[thread overview]
Message-ID: <20131011143145.GA1517@host2.jankratochvil.net> (raw)
In-Reply-To: <525806C8.8040108@codesourcery.com>

On Fri, 11 Oct 2013 16:10:16 +0200, Luis Machado wrote:
> --- a/gdb/gcore.in
> +++ b/gdb/gcore.in
> @@ -51,7 +51,7 @@ for pid in $*
>  do
>  	# `</dev/null' to avoid touching interactive terminal if it is
>  	# available but not accessible as GDB would get stopped on SIGTTIN.
> -	@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> +	"$(dirname "$0")"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \

I have only some concern if $0 does not contain a directory name.
Then `dirname basename` will be . and gdb -> ./gdb will be a regression as
./gdb will typically not be found.

For example if you run:
	$ sh gcore foo
then sh (or bash) executes /usr/bin/gcore but $0 is still just "gcore".

It IMO even corresponds to the sh $0 POSIX description ("command_file"):
	http://pubs.opengroup.org/onlinepubs/007908799/xcu/sh.html


Thanks,
Jan


  reply	other threads:[~2013-10-11 14:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 14:10 Luis Machado
2013-10-11 14:31 ` Jan Kratochvil [this message]
2013-10-11 14:46   ` Luis Machado
2013-10-11 16:46     ` Luis Machado
2013-10-11 16:56       ` Jan Kratochvil
2013-10-11 17:53         ` Luis Machado
2013-10-11 18:10           ` Jan Kratochvil
2013-10-11 18:22             ` Luis Machado
2013-10-11 19:58               ` Jan Kratochvil
2013-10-14 12:24                 ` Luis Machado
2013-10-15 15:10                   ` Jan Kratochvil
2013-10-16 15:13                     ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011143145.GA1517@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox