From: Luis Machado <lgustavo@codesourcery.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] Fix calling gcore when gdb is not in $PATH.
Date: Fri, 11 Oct 2013 14:10:00 -0000 [thread overview]
Message-ID: <525806C8.8040108@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
Hi,
Currently, the generated gcore scripts assume the gdb binary they need
to call is present in $PATH, but this may not always be true.
If you want to call the gcore scripts from a relative directory, for
example, it will fail to locate the gdb binary. The attached patch fixes
this.
Before the patch:
$ /tmp/gdb_test_install/bin/gcoreblahbleh 20000
/tmp/gdb_test_install/bin/gcoreblahbleh: 54:
/tmp/gdb_test_install/bin/gcoreblahbleh: gdbblahbleh: not found
gcoreblahbleh: failed to create core.20000
After the patch:
$ /tmp/gdb_test_install/bin/gcoreblahbleh 20000
warning: unable to open /proc file '/proc/20000/status'
warning: unable to open /proc file '/proc/20000/status'
ptrace: No such process.
You can't do that without a process to debug.
The program is not being run.
gcoreblahbleh: failed to create core.20000
How does it look?
Regards,
Luis
[-- Attachment #2: gcore.diff --]
[-- Type: text/x-patch, Size: 654 bytes --]
2013-10-11 Luis Machado <lgustavo@codesourcery.com>
* gcore.in: Call gdb using the full path to the gcore script.
diff --git a/gdb/gcore.in b/gdb/gcore.in
index 9c5b14d..b82479c 100644
--- a/gdb/gcore.in
+++ b/gdb/gcore.in
@@ -51,7 +51,7 @@ for pid in $*
do
# `</dev/null' to avoid touching interactive terminal if it is
# available but not accessible as GDB would get stopped on SIGTTIN.
- @GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
+ "$(dirname "$0")"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
-ex "set pagination off" -ex "set height 0" -ex "set width 0" \
-ex "attach $pid" -ex "gcore $name.$pid" -ex detach -ex quit
next reply other threads:[~2013-10-11 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 14:10 Luis Machado [this message]
2013-10-11 14:31 ` Jan Kratochvil
2013-10-11 14:46 ` Luis Machado
2013-10-11 16:46 ` Luis Machado
2013-10-11 16:56 ` Jan Kratochvil
2013-10-11 17:53 ` Luis Machado
2013-10-11 18:10 ` Jan Kratochvil
2013-10-11 18:22 ` Luis Machado
2013-10-11 19:58 ` Jan Kratochvil
2013-10-14 12:24 ` Luis Machado
2013-10-15 15:10 ` Jan Kratochvil
2013-10-16 15:13 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525806C8.8040108@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox