From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106274-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20328 invoked by alias); 11 Oct 2013 14:31:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20315 invoked by uid 89); 11 Oct 2013 14:31:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Oct 2013 14:31:52 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9BEVn5F002761	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 11 Oct 2013 10:31:49 -0400
Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9BEVjnn004714	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);	Fri, 11 Oct 2013 10:31:48 -0400
Date: Fri, 11 Oct 2013 14:31:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix calling gcore when gdb is not in $PATH.
Message-ID: <20131011143145.GA1517@host2.jankratochvil.net>
References: <525806C8.8040108@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <525806C8.8040108@codesourcery.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-10/txt/msg00387.txt.bz2

On Fri, 11 Oct 2013 16:10:16 +0200, Luis Machado wrote:
> --- a/gdb/gcore.in
> +++ b/gdb/gcore.in
> @@ -51,7 +51,7 @@ for pid in $*
>  do
>  	# `</dev/null' to avoid touching interactive terminal if it is
>  	# available but not accessible as GDB would get stopped on SIGTTIN.
> -	@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> +	"$(dirname "$0")"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \

I have only some concern if $0 does not contain a directory name.
Then `dirname basename` will be . and gdb -> ./gdb will be a regression as
./gdb will typically not be found.

For example if you run:
	$ sh gcore foo
then sh (or bash) executes /usr/bin/gcore but $0 is still just "gcore".

It IMO even corresponds to the sh $0 POSIX description ("command_file"):
	http://pubs.opengroup.org/onlinepubs/007908799/xcu/sh.html


Thanks,
Jan