Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jiong Wang <jiwang@tilera.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/TileGX 1/2] fix gdbserver build failure
Date: Tue, 17 Sep 2013 13:43:00 -0000	[thread overview]
Message-ID: <20130917134309.GI3132@adacore.com> (raw)
In-Reply-To: <52385AEF.5070404@tilera.com>

> linux-tile-low.o is the target file of TileGX. (it's name is confusing ?)
> 
> previous commit by the following wrongly removed the tilegx target file.
> 
> commit f7fc28008a4d76dd6e55eb77070eb18e956406a9
> Author: Luis Machado <luisgpm@br.ibm.com>
> Date: Thu Aug 22 23:46:27 2013 +0000
> 
> - srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o"
> - srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
> + srv_tgtobj="$srv_linux_obj linux-osdata.o"

Ok. Thank you for that, I had missed that commit in my research.
That goes to show how important it is to send detailed descriptions
of the problem when sending a patch. Otherwise, we end up wasting
time trying to figure it out again.

I knew what the file was about, and I knew it made sense. But I'd like
every patch to be explained on this list before it gets checked in.
This is for later on, when someone tries to figure out why a patch
was applied, at least it's documented in one public place.

Please go ahead and commit.

-- 
Joel


  reply	other threads:[~2013-09-17 13:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  9:23 [RFC/TileGX 1/6] fix args alignment bug Jiong Wang
2013-01-18 13:14 ` Joel Brobecker
2013-01-18 15:00   ` Jiong Wang
2013-01-22 10:28     ` Jiong Wang
2013-01-29 14:49       ` Jiong Wang
2013-01-30  4:34         ` Jiong Wang
2013-01-30  5:47           ` Joel Brobecker
2013-01-30  5:55             ` Jiong Wang
2013-02-08 18:33     ` Joel Brobecker
2013-09-17  3:11 ` [RFC/TileGX 1/2] fix gdbserver build failure Jiong Wang
2013-09-17  3:24   ` [RFC/TileGX 2/2] fix gdbserver runtime crash Jiong Wang
2013-09-17 12:33     ` Joel Brobecker
2013-09-17 12:39       ` Jiong Wang
2013-09-17 13:22         ` Jiong Wang
2013-09-17 13:29           ` Joel Brobecker
2013-09-17 14:06             ` [COMMITTED][RFC/TileGX " Jiong Wang
2013-09-17 12:30   ` [RFC/TileGX 1/2] fix gdbserver build failure Joel Brobecker
2013-09-17 12:33     ` Jiong Wang
2013-09-17 13:21       ` Jiong Wang
2013-09-17 13:30         ` Joel Brobecker
2013-09-17 13:36           ` Jiong Wang
2013-09-17 13:43             ` Joel Brobecker [this message]
2013-09-17 14:04               ` [COMMITTED][RFC/TileGX " Jiong Wang
2013-09-18  1:56                 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917134309.GI3132@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jiwang@tilera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox