From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15514 invoked by alias); 17 Sep 2013 13:43:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15502 invoked by uid 89); 17 Sep 2013 13:43:11 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 13:43:11 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3D5891165DD; Tue, 17 Sep 2013 09:43:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6d9OQ6cqiX9N; Tue, 17 Sep 2013 09:43:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0C6CD1165BC; Tue, 17 Sep 2013 09:43:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0AA66E1290; Tue, 17 Sep 2013 06:43:09 -0700 (PDT) Date: Tue, 17 Sep 2013 13:43:00 -0000 From: Joel Brobecker To: Jiong Wang Cc: gdb-patches@sourceware.org Subject: Re: [RFC/TileGX 1/2] fix gdbserver build failure Message-ID: <20130917134309.GI3132@adacore.com> References: <50F9148F.3010602@tilera.com> <5237C847.3040908@tilera.com> <20130917123042.GD3132@adacore.com> <52384C0E.1070808@tilera.com> <5238574F.1000509@tilera.com> <20130917133023.GG3132@adacore.com> <52385AEF.5070404@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52385AEF.5070404@tilera.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00509.txt.bz2 > linux-tile-low.o is the target file of TileGX. (it's name is confusing ?) > > previous commit by the following wrongly removed the tilegx target file. > > commit f7fc28008a4d76dd6e55eb77070eb18e956406a9 > Author: Luis Machado > Date: Thu Aug 22 23:46:27 2013 +0000 > > - srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o" > - srv_tgtobj="${srv_tgtobj} linux-ptrace.o" > + srv_tgtobj="$srv_linux_obj linux-osdata.o" Ok. Thank you for that, I had missed that commit in my research. That goes to show how important it is to send detailed descriptions of the problem when sending a patch. Otherwise, we end up wasting time trying to figure it out again. I knew what the file was about, and I knew it made sense. But I'd like every patch to be explained on this list before it gets checked in. This is for later on, when someone tries to figure out why a patch was applied, at least it's documented in one public place. Please go ahead and commit. -- Joel