Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jiong Wang <jiwang@tilera.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/TileGX 2/2] fix gdbserver runtime crash
Date: Tue, 17 Sep 2013 12:33:00 -0000	[thread overview]
Message-ID: <20130917123304.GE3132@adacore.com> (raw)
In-Reply-To: <5237CB65.4000703@tilera.com>

> TileGX is always 64bit, ptrace always return 64bit data,  tilegx32
> is just an ABI.
> 
> So the regset size should be regnum * 8 instead of regnum * 4. The
> latter cause gdbserver crash.
> 
> gdbserver/ChangeLog:
> 
>   * linux-tile-low.c (tile_regsets): Modify the size field as 64bit
> for each register.

I will trust you on this one, but how did this even work at all
prior to your change???

> diff --git a/gdb/gdbserver/linux-tile-low.c b/gdb/gdbserver/linux-tile-low.c
> index 8963b9a..8efb34e 100644
> --- a/gdb/gdbserver/linux-tile-low.c
> +++ b/gdb/gdbserver/linux-tile-low.c
> @@ -124,7 +124,7 @@ tile_store_gregset (struct regcache *regcache, const void *buf)
>  
>  static struct regset_info tile_regsets[] =
>  {
> -  { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
> +  { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
>      GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
>    { 0, 0, 0, -1, -1, NULL, NULL }
>  };


-- 
Joel


  reply	other threads:[~2013-09-17 12:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  9:23 [RFC/TileGX 1/6] fix args alignment bug Jiong Wang
2013-01-18 13:14 ` Joel Brobecker
2013-01-18 15:00   ` Jiong Wang
2013-01-22 10:28     ` Jiong Wang
2013-01-29 14:49       ` Jiong Wang
2013-01-30  4:34         ` Jiong Wang
2013-01-30  5:47           ` Joel Brobecker
2013-01-30  5:55             ` Jiong Wang
2013-02-08 18:33     ` Joel Brobecker
2013-09-17  3:11 ` [RFC/TileGX 1/2] fix gdbserver build failure Jiong Wang
2013-09-17  3:24   ` [RFC/TileGX 2/2] fix gdbserver runtime crash Jiong Wang
2013-09-17 12:33     ` Joel Brobecker [this message]
2013-09-17 12:39       ` Jiong Wang
2013-09-17 13:22         ` Jiong Wang
2013-09-17 13:29           ` Joel Brobecker
2013-09-17 14:06             ` [COMMITTED][RFC/TileGX " Jiong Wang
2013-09-17 12:30   ` [RFC/TileGX 1/2] fix gdbserver build failure Joel Brobecker
2013-09-17 12:33     ` Jiong Wang
2013-09-17 13:21       ` Jiong Wang
2013-09-17 13:30         ` Joel Brobecker
2013-09-17 13:36           ` Jiong Wang
2013-09-17 13:43             ` Joel Brobecker
2013-09-17 14:04               ` [COMMITTED][RFC/TileGX " Jiong Wang
2013-09-18  1:56                 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917123304.GE3132@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jiwang@tilera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox