From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Yao Qi <yao@codesourcery.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/3] Detect GDB is in cygwin
Date: Sat, 03 Aug 2013 04:55:00 -0000 [thread overview]
Message-ID: <20130803045452.GA997@ednor.casa.cgf.cx> (raw)
In-Reply-To: <51FA137B.6070207@codesourcery.com>
On Thu, Aug 01, 2013 at 03:51:23PM +0800, Yao Qi wrote:
>On 07/30/2013 11:33 PM, Eli Zaretskii wrote:
>> There's no need to probe that at configure time: this code can always
>> be compiled on any MS-Windows system. The compiler doesn't care and
>> doesn't check at compile time whether there is in fact
>> NtQueryInformationFile function inside the DLL.
>
>OK. If so, in configure.ac, we only need to check headers, and don't need
>AC_TRY_COMPILE at all. Here is the updated one, with several changes,
>
> - Remove AC_TRY_COMPILE,
> - Include fewer headers in mingw-htep.c, and don't have to check them
>in configure.ac.
> - Rename is_in_cygwin to using_cygwin_pty,
This patch relies on low-level, unadvertised properties of the Cygwin DLL.
Are you sure it doesn't detect a cygwin pipe as a pty?
cgf
next prev parent reply other threads:[~2013-08-03 4:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 8:46 [PATCH 0/3 V3] Test mingw32 GDB " Yao Qi
2013-07-29 8:46 ` [PATCH 1/3] Detect GDB is " Yao Qi
2013-07-29 15:38 ` Eli Zaretskii
2013-07-30 9:27 ` Yao Qi
2013-07-30 15:33 ` Eli Zaretskii
2013-08-01 7:52 ` Yao Qi
2013-08-01 16:33 ` Eli Zaretskii
2013-08-02 2:51 ` Yao Qi
2013-08-02 6:10 ` Eli Zaretskii
2013-08-03 4:55 ` Christopher Faylor [this message]
2013-08-04 8:45 ` Yao Qi
2013-08-05 4:41 ` Christopher Faylor
2013-08-05 6:23 ` Yao Qi
2013-08-06 2:08 ` Christopher Faylor
2013-08-06 3:05 ` Yao Qi
2013-08-08 5:11 ` Christopher Faylor
2013-08-08 7:24 ` Yao Qi
2013-08-15 17:40 ` Christopher Faylor
2013-08-15 18:58 ` Tom Tromey
2013-08-15 19:14 ` Eli Zaretskii
2013-08-16 0:06 ` Yao Qi
2013-08-16 2:01 ` Tom Tromey
2013-08-16 1:07 ` Yao Qi
2013-08-16 16:37 ` Christopher Faylor
2013-08-08 7:28 ` Pierre Muller
2013-08-13 8:12 ` Yao Qi
2013-08-13 8:23 ` Pierre Muller
2013-07-29 8:46 ` [PATCH 2/3] Unbuffer stdout and stderr " Yao Qi
2013-07-29 15:42 ` Eli Zaretskii
2013-08-01 8:06 ` Yao Qi
2013-08-01 16:36 ` Eli Zaretskii
2013-08-02 0:40 ` Yao Qi
2013-07-29 8:46 ` [PATCH 3/3] Set stdin/stdout/stderr to binary mode " Yao Qi
2013-07-29 15:44 ` Eli Zaretskii
2013-08-01 8:10 ` Yao Qi
2013-08-01 16:37 ` Eli Zaretskii
2013-07-29 14:03 ` [PATCH 0/3 V3] Test mingw32 GDB " Pierre Muller
2013-07-30 6:03 ` Yao Qi
2013-07-29 18:03 ` Tom Tromey
2013-07-29 18:43 ` Eli Zaretskii
2013-08-13 9:35 [PATCH 0/3 V4] " Yao Qi
2013-08-13 9:35 ` [PATCH 1/3] Detect GDB is " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130803045452.GA997@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox