From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Unbuffer stdout and stderr in cygwin
Date: Mon, 29 Jul 2013 15:42:00 -0000 [thread overview]
Message-ID: <83siyxxtif.fsf@gnu.org> (raw)
In-Reply-To: <1375087546-22591-3-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Mon, 29 Jul 2013 16:45:45 +0800
>
> +#ifdef __MINGW32__
> + if (is_in_cygwin_p ())
I would suggest to call the function using_cygwin_pty or some such.
"is_in_cygwin" is IMO too ambiguous.
> + setvbuf (stdout, NULL, _IONBF, BUFSIZ);
> + setvbuf (stderr, NULL, _IONBF, BUFSIZ);
How about using line buffering instead on both streams? Or at least
leave stdout line-buffered? Did you try that, and if so, did that
have the same problems that triggered these patches?
You see, the way your patch works, using GDB from a Cygwin shell
window will always do the above, even when not running the test
suite. Users might be unhappy that their standard output suddenly
becomes much less efficient.
next prev parent reply other threads:[~2013-07-29 15:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 8:46 [PATCH 0/3 V3] Test mingw32 GDB " Yao Qi
2013-07-29 8:46 ` [PATCH 2/3] Unbuffer stdout and stderr " Yao Qi
2013-07-29 15:42 ` Eli Zaretskii [this message]
2013-08-01 8:06 ` Yao Qi
2013-08-01 16:36 ` Eli Zaretskii
2013-08-02 0:40 ` Yao Qi
2013-07-29 8:46 ` [PATCH 1/3] Detect GDB is " Yao Qi
2013-07-29 15:38 ` Eli Zaretskii
2013-07-30 9:27 ` Yao Qi
2013-07-30 15:33 ` Eli Zaretskii
2013-08-01 7:52 ` Yao Qi
2013-08-01 16:33 ` Eli Zaretskii
2013-08-02 2:51 ` Yao Qi
2013-08-02 6:10 ` Eli Zaretskii
2013-08-03 4:55 ` Christopher Faylor
2013-08-04 8:45 ` Yao Qi
2013-08-05 4:41 ` Christopher Faylor
2013-08-05 6:23 ` Yao Qi
2013-08-06 2:08 ` Christopher Faylor
2013-08-06 3:05 ` Yao Qi
2013-08-08 5:11 ` Christopher Faylor
2013-08-08 7:24 ` Yao Qi
2013-08-15 17:40 ` Christopher Faylor
2013-08-15 18:58 ` Tom Tromey
2013-08-15 19:14 ` Eli Zaretskii
2013-08-16 0:06 ` Yao Qi
2013-08-16 2:01 ` Tom Tromey
2013-08-16 1:07 ` Yao Qi
2013-08-16 16:37 ` Christopher Faylor
2013-08-08 7:28 ` Pierre Muller
2013-08-13 8:12 ` Yao Qi
2013-08-13 8:23 ` Pierre Muller
2013-07-29 8:46 ` [PATCH 3/3] Set stdin/stdout/stderr to binary mode " Yao Qi
2013-07-29 15:44 ` Eli Zaretskii
2013-08-01 8:10 ` Yao Qi
2013-08-01 16:37 ` Eli Zaretskii
2013-07-29 14:03 ` [PATCH 0/3 V3] Test mingw32 GDB " Pierre Muller
2013-07-30 6:03 ` Yao Qi
2013-07-29 18:03 ` Tom Tromey
2013-07-29 18:43 ` Eli Zaretskii
2013-08-13 9:35 [PATCH 0/3 V4] " Yao Qi
2013-08-13 9:35 ` [PATCH 2/3] Unbuffer stdout and stderr " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83siyxxtif.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox