From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1036 invoked by alias); 3 Aug 2013 04:55:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1022 invoked by uid 89); 3 Aug 2013 04:55:06 -0000 X-Spam-SWARE-Status: No, score=-50.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 03 Aug 2013 04:55:03 +0000 Received: from pool-173-48-46-190.bstnma.fios.verizon.net ([173.48.46.190] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1V5Trj-000IEA-JR; Sat, 03 Aug 2013 04:54:55 +0000 Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 56A6660136; Sat, 3 Aug 2013 00:54:52 -0400 (EDT) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/FoZZce6KQ/fqTQooXZStH Date: Sat, 03 Aug 2013 04:55:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Yao Qi , Eli Zaretskii Subject: Re: [PATCH 1/3] Detect GDB is in cygwin Message-ID: <20130803045452.GA997@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Yao Qi , Eli Zaretskii References: <1375087546-22591-1-git-send-email-yao@codesourcery.com> <1375087546-22591-2-git-send-email-yao@codesourcery.com> <83txjdxtpd.fsf@gnu.org> <51F786CB.3020700@codesourcery.com> <83a9l4xdst.fsf@gnu.org> <51FA137B.6070207@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51FA137B.6070207@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-08/txt/msg00121.txt.bz2 On Thu, Aug 01, 2013 at 03:51:23PM +0800, Yao Qi wrote: >On 07/30/2013 11:33 PM, Eli Zaretskii wrote: >> There's no need to probe that at configure time: this code can always >> be compiled on any MS-Windows system. The compiler doesn't care and >> doesn't check at compile time whether there is in fact >> NtQueryInformationFile function inside the DLL. > >OK. If so, in configure.ac, we only need to check headers, and don't need >AC_TRY_COMPILE at all. Here is the updated one, with several changes, > > - Remove AC_TRY_COMPILE, > - Include fewer headers in mingw-htep.c, and don't have to check them >in configure.ac. > - Rename is_in_cygwin to using_cygwin_pty, This patch relies on low-level, unadvertised properties of the Cygwin DLL. Are you sure it doesn't detect a cygwin pipe as a pty? cgf