From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] New option --cygwin-tty.
Date: Thu, 25 Jul 2013 15:21:00 -0000 [thread overview]
Message-ID: <20130725152128.GI5086@calimero.vinschen.de> (raw)
In-Reply-To: <51F11502.1070104@codesourcery.com>
On Jul 25 20:07, Yao Qi wrote:
> On 07/25/2013 06:19 PM, Corinna Vinschen wrote:
> >>What is the minimum version of cygwin required for this example? In
> >>>cygwin 1.7.20, the file name is
> >>>"\cygwin-8c26184c318518a4-pty0-from-master", while in 1.7.9, it is
> >>>"\cygwin-c5e39b7a9d22bafb-tty0-from-master".
> >Read the source code comments. The hex number is a per-installation
> >hash value which does not tell anything about the Cygwin version. The
> >earliest supported Cygwin version is 1.7.0, so the answer is "all of
> >them" for all practical purposes.
>
> My point was about the "pty0" vs "tty0" difference in the file name.
> If the difference is expected, I'll update the name pattern in the
> code. Your example expects to see "pty".
Oh, ok, I missed that. Just tweak the code to check for both if you
want to support old Cygwin versions. But this isn't necessary IMO.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
next prev parent reply other threads:[~2013-07-25 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 5:10 [PATCH 0/3] Test mingw32 GDB in cygwin Yao Qi
2013-07-25 5:10 ` [PATCH 3/3] native mingw32 gdb, eol format Yao Qi
2013-07-25 5:10 ` [PATCH 2/3] Unbuffer stdout and stderr on windows Yao Qi
2013-07-25 5:10 ` [PATCH 1/3] New option --cygwin-tty Yao Qi
2013-07-25 7:34 ` Corinna Vinschen
2013-07-25 7:37 ` Pierre Muller
2013-07-25 7:55 ` Yao Qi
2013-07-25 8:18 ` Corinna Vinschen
2013-07-25 8:26 ` Corinna Vinschen
2013-07-25 9:05 ` Yao Qi
2013-07-25 10:20 ` Corinna Vinschen
2013-07-25 12:08 ` Yao Qi
2013-07-25 15:21 ` Corinna Vinschen [this message]
2013-07-26 19:40 ` Doug Evans
2013-07-25 7:31 ` [PATCH 0/3] Test mingw32 GDB in cygwin Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725152128.GI5086@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox