From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10110 invoked by alias); 25 Jul 2013 15:21:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10101 invoked by uid 89); 25 Jul 2013 15:21:38 -0000 X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_40,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Jul 2013 15:21:37 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id B88465200A1; Thu, 25 Jul 2013 17:21:28 +0200 (CEST) Date: Thu, 25 Jul 2013 15:21:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] New option --cygwin-tty. Message-ID: <20130725152128.GI5086@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <1374728963-25187-1-git-send-email-yao@codesourcery.com> <1374728963-25187-2-git-send-email-yao@codesourcery.com> <000901ce8909$dd069470$9713bd50$@muller@ics-cnrs.unistra.fr> <51F0D9D2.1090804@codesourcery.com> <20130725081820.GA11021@calimero.vinschen.de> <51F0EA14.1070900@codesourcery.com> <20130725101948.GA30499@calimero.vinschen.de> <51F11502.1070104@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51F11502.1070104@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-07/txt/msg00617.txt.bz2 On Jul 25 20:07, Yao Qi wrote: > On 07/25/2013 06:19 PM, Corinna Vinschen wrote: > >>What is the minimum version of cygwin required for this example? In > >>>cygwin 1.7.20, the file name is > >>>"\cygwin-8c26184c318518a4-pty0-from-master", while in 1.7.9, it is > >>>"\cygwin-c5e39b7a9d22bafb-tty0-from-master". > >Read the source code comments. The hex number is a per-installation > >hash value which does not tell anything about the Cygwin version. The > >earliest supported Cygwin version is 1.7.0, so the answer is "all of > >them" for all practical purposes. > > My point was about the "pty0" vs "tty0" difference in the file name. > If the difference is expected, I'll update the name pattern in the > code. Your example expects to see "pty". Oh, ok, I missed that. Just tweak the code to check for both if you want to support old Cygwin versions. But this isn't necessary IMO. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat