Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Yao Qi'" <yao@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: RE: [PATCH 0/3] Test mingw32 GDB in cygwin
Date: Thu, 25 Jul 2013 07:31:00 -0000	[thread overview]
Message-ID: <000601ce8909$02483280$06d89780$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <1374728963-25187-1-git-send-email-yao@codesourcery.com>

  Hi all,

  while I find that this patch series is really a big improvement
towards getting usable results for Windows OS native GDB,
I must say that I do not like at all the name of the new
command line option.

  Indeed, I tested your previous patches on a current trunk CVS
source compiled on msys system configured as i686-pc-mingw32.
  I am using an old dejagnu port for msys
which basically suffers the problems a you describe for mingw32 GDB
on a cygwin tty.
  
  But to me it seems rather odd that we should use --cygwin-tty
option on an msys terminal.
  Maybe --windows-so-tty would be more appropriate?

Pierre Muller  

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Yao Qi
> Envoyé : jeudi 25 juillet 2013 07:09
> À : gdb-patches@sourceware.org
> Objet : [PATCH 0/3] Test mingw32 GDB in cygwin
> 
> Hi,
> This patch series try to fix the problems we've seen on running
> mingw32 native for testing in cygwin tty.  Patch 2/3 unbuffer the
> stdout and stderr, so that dejagnu/expect can match the output in
> the right order.  Likewise, patch 3/3 sets stdin/stdout/stderr into
> binary mode, so that dejagnu/expects can match the eol correctly
> too.
> 
> Patch 2/3 and 3/3 was posted last week,
> 
>   http://sourceware.org/ml/gdb-patches/2013-07/msg00481.html
>   http://sourceware.org/ml/gdb-patches/2013-07/msg00358.html
> 
> and one review comment is that these changes affect the behavior of
> mingw32 GDB as a typical native win32 application.  In order to
> remove this side effect, a new option '--cyginw-tty' is added in
> patch 1/3, which tells GDB that it is running in Cygwin TTY.
> 
> The whole series are tested on native mingw32 GDB running in cygwin.
> Test results are improved dramatically.
> 
> *** BLURB HERE ***
> 
> Yao Qi (3):
>   New option --cygwin-tty.
>   Unbuffer stdout and stderr on windows
>   native mingw32 gdb, eol format
> 
>  gdb/NEWS                         |    4 +++
>  gdb/defs.h                       |    4 +++
>  gdb/main.c                       |   54
> ++++++++++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/dbx.exp   |    3 +-
>  gdb/testsuite/lib/gdb.exp        |   35 +++++++++++++++++++++++-
>  gdb/testsuite/lib/mi-support.exp |    3 +-
>  6 files changed, 99 insertions(+), 4 deletions(-)
> 
> --
> 1.7.7.6



      parent reply	other threads:[~2013-07-25  7:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  5:10 Yao Qi
2013-07-25  5:10 ` [PATCH 2/3] Unbuffer stdout and stderr on windows Yao Qi
2013-07-25  5:10 ` [PATCH 3/3] native mingw32 gdb, eol format Yao Qi
2013-07-25  5:10 ` [PATCH 1/3] New option --cygwin-tty Yao Qi
2013-07-25  7:34   ` Corinna Vinschen
2013-07-25  7:37   ` Pierre Muller
2013-07-25  7:55     ` Yao Qi
2013-07-25  8:18       ` Corinna Vinschen
2013-07-25  8:26         ` Corinna Vinschen
2013-07-25  9:05         ` Yao Qi
2013-07-25 10:20           ` Corinna Vinschen
2013-07-25 12:08             ` Yao Qi
2013-07-25 15:21               ` Corinna Vinschen
2013-07-26 19:40       ` Doug Evans
2013-07-25  7:31 ` Pierre Muller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601ce8909$02483280$06d89780$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox