Re: [PATCH] Enable hw watchpoint with longer ranges using DAWR on Power

["Ulrich Weigand" <uweigand@de.ibm.com>]

Luis Machado wrote:
> On 07/02/2013 02:39 PM, Edjunior Barbosa Machado wrote:
> > gdb/ChangeLog
> > 2013-07-02  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> >
> > 	* ppc-linux-nat.c (PPC_DEBUG_FEATURE_DATA_BP_DAWR): New define.
> > 	(ppc_linux_region_ok_for_hw_watchpoint): Add checking to use the new
> > 	DAWR interface for longer ranges hardware watchpoint (up to 512 bytes).

This looks good to me too, but we should indeed probably sort out
the booke renaming first :-)

> > +#ifndef PPC_DEBUG_FEATURE_DATA_BP_DAWR
> > +#define PPC_DEBUG_FEATURE_DATA_BP_DAWR	0x10
> > +#endif /* PPC_DEBUG_FEATURE_DATA_BP_DAWR */
> >
> 
> Are older kernels/libraries that don't define these constants going to 
> be used with these POWER processors in the future? If not, maybe they 
> can be dropped instead of forcing their definitions here.

In general, we usually always provide such defines.  There should be
no harm in doing so, since this is kernel ABI that will never change,
so it is fine to just use the well-known binary value ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com