From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15542 invoked by alias); 2 Jul 2013 18:04:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15504 invoked by uid 89); 2 Jul 2013 18:04:40 -0000 X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 18:04:39 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Jul 2013 19:02:08 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 2 Jul 2013 19:02:06 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 43F721B08023 for ; Tue, 2 Jul 2013 19:04:35 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r62I4NsJ57933950 for ; Tue, 2 Jul 2013 18:04:23 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r62I4XbK017652 for ; Tue, 2 Jul 2013 12:04:34 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id r62I4WBg017601; Tue, 2 Jul 2013 12:04:32 -0600 Message-Id: <201307021804.r62I4WBg017601@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 02 Jul 2013 20:04:32 +0200 Subject: Re: [PATCH] Enable hw watchpoint with longer ranges using DAWR on Power To: lgustavo@codesourcery.com Date: Tue, 02 Jul 2013 18:04:00 -0000 From: "Ulrich Weigand" Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com (Ulrich Weigand) In-Reply-To: <51D31512.7020005@codesourcery.com> from "Luis Machado" at Jul 02, 2013 02:59:46 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13070218-4966-0000-0000-0000062E519D X-SW-Source: 2013-07/txt/msg00088.txt.bz2 Luis Machado wrote: > On 07/02/2013 02:39 PM, Edjunior Barbosa Machado wrote: > > gdb/ChangeLog > > 2013-07-02 Edjunior Barbosa Machado > > > > * ppc-linux-nat.c (PPC_DEBUG_FEATURE_DATA_BP_DAWR): New define. > > (ppc_linux_region_ok_for_hw_watchpoint): Add checking to use the new > > DAWR interface for longer ranges hardware watchpoint (up to 512 bytes). This looks good to me too, but we should indeed probably sort out the booke renaming first :-) > > +#ifndef PPC_DEBUG_FEATURE_DATA_BP_DAWR > > +#define PPC_DEBUG_FEATURE_DATA_BP_DAWR 0x10 > > +#endif /* PPC_DEBUG_FEATURE_DATA_BP_DAWR */ > > > > Are older kernels/libraries that don't define these constants going to > be used with these POWER processors in the future? If not, maybe they > can be dropped instead of forcing their definitions here. In general, we usually always provide such defines. There should be no harm in doing so, since this is kernel ABI that will never change, so it is fine to just use the well-known binary value ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com