From: DJ Delorie <dj@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: nickc@redhat.com, binutils@sourceware.org, kevinb@redhat.com,
gdb-patches@sourceware.org
Subject: Re: [RFC] msp430 instruction decoder
Date: Thu, 23 May 2013 05:48:00 -0000 [thread overview]
Message-ID: <201305230548.r4N5m5wU021691@greed.delorie.com> (raw)
In-Reply-To: <201305230116.28453.vapier@gentoo.org> (message from Mike Frysinger on Thu, 23 May 2013 01:16:26 -0400)
> - in msp430_decode_opcode, are the multiple macro calls on the same line on=20
> purpose, or should those get fixed to be one per line ? for example:
> ID (dopc_to_id (dopc)); ASX (sreg, as, srxt_bits); ADX (dreg, a, dsxt_bits);=20
> ABW (al_bit, b);
On purpose. The order of the macros is important, and they typically
correspond to bits in the bit pattern above it. So the "common"
macros that pull out fields were kept on one line.
Plus, the source would be very white-heavy if you had one tiny macro
on each line ;-)
prev parent reply other threads:[~2013-05-23 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 22:03 Kevin Buettner
2013-05-16 22:33 ` Kevin Buettner
2013-05-17 17:54 ` Mike Frysinger
2013-05-22 10:14 ` nick clifton
2013-05-23 5:16 ` Mike Frysinger
2013-05-23 5:48 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305230548.r4N5m5wU021691@greed.delorie.com \
--to=dj@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=nickc@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox