From: Mike Frysinger <vapier@gentoo.org>
To: binutils@sourceware.org
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] msp430 instruction decoder
Date: Fri, 17 May 2013 17:54:00 -0000 [thread overview]
Message-ID: <201305171354.20292.vapier@gentoo.org> (raw)
In-Reply-To: <20130516150246.2463f977@mesquite.lan>
[-- Attachment #1: Type: Text/Plain, Size: 732 bytes --]
On Thursday 16 May 2013 18:02:46 Kevin Buettner wrote:
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ msp430-decode.c 16 May 2013 21:31:35 -0000
typically it's better to omit generated files from patches posted to the list.
it's often times a lot of noise (like in this case).
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ msp430-decode.opc 16 May 2013 21:31:35 -0000
> @@ -0,0 +1,572 @@
> +/* -*- c -*- */
missing standard copyright/license block
> +typedef struct
> +{
> + MSP430_Opcode_Decoded * msp430;
shouldn't the style be:
MSP430_Opcode_Decoded *msp430;
seems like general style guidelines are violated a lot in this file. do we
normally ignore that in the opcodes/ tree ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-17 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 22:03 Kevin Buettner
2013-05-16 22:33 ` Kevin Buettner
2013-05-17 17:54 ` Mike Frysinger [this message]
2013-05-22 10:14 ` nick clifton
2013-05-23 5:16 ` Mike Frysinger
2013-05-23 5:48 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305171354.20292.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox