From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14178 invoked by alias); 17 May 2013 17:54:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14163 invoked by uid 89); 17 May 2013 17:54:19 -0000 X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 17:54:19 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id C925233E2A6; Fri, 17 May 2013 17:54:17 +0000 (UTC) From: Mike Frysinger To: binutils@sourceware.org Subject: Re: [RFC] msp430 instruction decoder Date: Fri, 17 May 2013 17:54:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: Kevin Buettner , gdb-patches@sourceware.org References: <20130516150246.2463f977@mesquite.lan> In-Reply-To: <20130516150246.2463f977@mesquite.lan> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6718068.RCuk04Seqt"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201305171354.20292.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00694.txt.bz2 --nextPart6718068.RCuk04Seqt Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 718 On Thursday 16 May 2013 18:02:46 Kevin Buettner wrote: > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ msp430-decode.c 16 May 2013 21:31:35 -0000 typically it's better to omit generated files from patches posted to the li= st.=20=20 it's often times a lot of noise (like in this case). > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ msp430-decode.opc 16 May 2013 21:31:35 -0000 > @@ -0,0 +1,572 @@ > +/* -*- c -*- */ missing standard copyright/license block > +typedef struct > +{ > + MSP430_Opcode_Decoded * msp430; shouldn't the style be: MSP430_Opcode_Decoded *msp430; seems like general style guidelines are violated a lot in this file. do we= =20 normally ignore that in the opcodes/ tree ? -mike --nextPart6718068.RCuk04Seqt Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRlm7MAAoJEEFjO5/oN/WBnuEP/0DA/WQC/Zjvj8fw2JTD1t/r EWZXlpciStzqbluba888tNtz82uvSmPHUVDaY6BEAkiSIL1tB5JOsC+9GHiy9nxr T4Y3my2nyQ+ZOh4xN3HtvnssEhP/pbhQSTteVXtBHdq179pTsOHFDU3q0JOEMvpR DBvJBfG312OInQivGULdN17usdslle8q6XIZfAmb2rvCoImz42qkBPiBh6fJZMKW 3vEM8ODu42PDHyCeW0JdyV4U10WNcEyQ8z0v0zacB2grop55qug3MYbfwFKjfn1/ FkUIUZ5FGTOxfVDCMdueai4oJME9VA3Aige5amYS/VhHLvNbx2YJ/kPN4dgEn4lF hMu2WQL8C/aVvcds+T23UEQlubvKignhC4rg9w/aU61YSZeZL9+ewe2rDLzonNEi XGNOY2BoRKSRcHAmnbs4pOMBqUyZ8r3WvQSwSvz7NVAtV1rQbs3ucgm8+HSvR1NU sUJOshahU7Jb/mPWipHXjnXZTl6tXTRbbJc7+ZggUlJqG5MrJtkFB8+HetEh1hcL aMUcprnaLHS1YSUCTRAHafMEejoRqemPB1LXpJULCDQNohDGya0WA/kOU5J7Z1Cl GaCQmIFmmgdnkfk7JVyGVID20LpoLS7Sa6sMIpMrJGtSkyWPNmBo2JwfhamePH0s rZvRlWdU3F878Mn3cds/ =5gw3 -----END PGP SIGNATURE----- --nextPart6718068.RCuk04Seqt--