From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22442 invoked by alias); 23 May 2013 05:48:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22423 invoked by uid 89); 23 May 2013 05:48:12 -0000 X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 05:48:11 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4N5m69p026475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 May 2013 01:48:06 -0400 Received: from greed.delorie.com (ovpn-113-43.phx2.redhat.com [10.3.113.43]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4N5m6U4026100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 23 May 2013 01:48:06 -0400 Received: from greed.delorie.com (greed.delorie.com [127.0.0.1]) by greed.delorie.com (8.14.4/8.14.4) with ESMTP id r4N5m5pO021692; Thu, 23 May 2013 01:48:05 -0400 Received: (from dj@localhost) by greed.delorie.com (8.14.4/8.14.4/Submit) id r4N5m5wU021691; Thu, 23 May 2013 01:48:05 -0400 Date: Thu, 23 May 2013 05:48:00 -0000 Message-Id: <201305230548.r4N5m5wU021691@greed.delorie.com> From: DJ Delorie To: Mike Frysinger CC: nickc@redhat.com, binutils@sourceware.org, kevinb@redhat.com, gdb-patches@sourceware.org In-reply-to: <201305230116.28453.vapier@gentoo.org> (message from Mike Frysinger on Thu, 23 May 2013 01:16:26 -0400) Subject: Re: [RFC] msp430 instruction decoder References: <20130516150246.2463f977@mesquite.lan> <201305171354.20292.vapier@gentoo.org> <519C9A46.4010302@redhat.com> <201305230116.28453.vapier@gentoo.org> X-SW-Source: 2013-05/txt/msg00867.txt.bz2 > - in msp430_decode_opcode, are the multiple macro calls on the same line on=20 > purpose, or should those get fixed to be one per line ? for example: > ID (dopc_to_id (dopc)); ASX (sreg, as, srxt_bits); ADX (dreg, a, dsxt_bits);=20 > ABW (al_bit, b); On purpose. The order of the macros is important, and they typically correspond to bits in the bit pattern above it. So the "common" macros that pull out fields were kept on one line. Plus, the source would be very white-heavy if you had one tiny macro on each line ;-)