From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Thread exit messages on MS-Windows
Date: Mon, 29 Apr 2013 08:21:00 -0000 [thread overview]
Message-ID: <20130427181040.GA7166@calimero.vinschen.de> (raw)
In-Reply-To: <8361z8tkjk.fsf@gnu.org>
On Apr 27 12:00, Eli Zaretskii wrote:
> One minor correction:
>
> > + else if (print_thread_events && id != main_thread_id)
> > + printf_unfiltered (_("[%s exited with code %d]\n"),
> ^^
> This should be %lu, not %d.
If this code is generic and runs under Cygwin as well, then please make
that %u, not %lu. DWORD is a 4 byte value and under 64 bit Cygwin
(LP64), it's not the same as long, but as int. Alternatively, add an
explicit cast to unsigned long to the argument.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
next prev parent reply other threads:[~2013-04-27 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83obd1tyi7.fsf@gnu.org>
2013-04-28 16:24 ` Eli Zaretskii
2013-04-29 4:32 ` Eli Zaretskii
2013-04-29 8:21 ` Corinna Vinschen [this message]
2013-04-29 8:38 ` Eli Zaretskii
2013-04-29 5:09 ` asmwarrior
2013-04-29 6:30 ` Eli Zaretskii
2013-04-29 6:30 ` asmwarrior
2013-04-29 6:30 ` Eli Zaretskii
2013-04-29 17:31 ` Joel Brobecker
2013-04-29 20:27 ` Eli Zaretskii
2013-04-30 11:51 ` Joel Brobecker
2013-04-29 19:26 ` Tom Tromey
2013-04-30 0:58 ` Eli Zaretskii
2013-04-30 11:38 ` Joel Brobecker
[not found] ` <83obcwoubz.fsf@gnu.org>
2013-05-01 5:14 ` Joel Brobecker
2013-05-04 13:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130427181040.GA7166@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox