From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26315 invoked by alias); 27 Apr 2013 18:10:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26303 invoked by uid 89); 27 Apr 2013 18:10:44 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Apr 2013 18:10:42 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 21F045201EC; Sat, 27 Apr 2013 20:10:40 +0200 (CEST) Date: Mon, 29 Apr 2013 08:21:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] Thread exit messages on MS-Windows Message-ID: <20130427181040.GA7166@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <83obd1tyi7.fsf@gnu.org> <838v44tnf8.fsf@gnu.org> <8361z8tkjk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8361z8tkjk.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00848.txt.bz2 On Apr 27 12:00, Eli Zaretskii wrote: > One minor correction: > > > + else if (print_thread_events && id != main_thread_id) > > + printf_unfiltered (_("[%s exited with code %d]\n"), > ^^ > This should be %lu, not %d. If this code is generic and runs under Cygwin as well, then please make that %u, not %lu. DWORD is a 4 byte value and under 64 bit Cygwin (LP64), it's not the same as long, but as int. Alternatively, add an explicit cast to unsigned long to the argument. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat