From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Thread exit messages on MS-Windows
Date: Tue, 30 Apr 2013 11:51:00 -0000 [thread overview]
Message-ID: <20130430072725.GA3525@adacore.com> (raw)
In-Reply-To: <83ppxdqs2i.fsf@gnu.org>
> I know what to do with Corinna's comment, but not what to decide about
> announcing the death of the main thread. Do you have an opinion?
No strong opinion, but I share your preference.
> My reading of the code is that you already see that in linux-native
> debugging, see linux-nat.c.
'must have missed it... sorry :).
> > One tiny nitpick, very possibly influenced by personal preferences,
> > so feel free to ignore... I think that the code would be faster
> > to read if the added parameter was moved to the next line. That way,
> > all parameters in call to windows_delete_thread would have the same
> > indentation level.
>
> I'm surprised, but I don't mind, and will do that, too.
Then don't. It's such a small comment that it's not worth changing.
--
Joel
next prev parent reply other threads:[~2013-04-30 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83obd1tyi7.fsf@gnu.org>
2013-04-28 16:24 ` Eli Zaretskii
2013-04-29 4:32 ` Eli Zaretskii
2013-04-29 8:21 ` Corinna Vinschen
2013-04-29 8:38 ` Eli Zaretskii
2013-04-29 5:09 ` asmwarrior
2013-04-29 6:30 ` Eli Zaretskii
2013-04-29 6:30 ` asmwarrior
2013-04-29 6:30 ` Eli Zaretskii
2013-04-29 17:31 ` Joel Brobecker
2013-04-29 20:27 ` Eli Zaretskii
2013-04-30 11:51 ` Joel Brobecker [this message]
2013-04-29 19:26 ` Tom Tromey
2013-04-30 0:58 ` Eli Zaretskii
2013-04-30 11:38 ` Joel Brobecker
[not found] ` <83obcwoubz.fsf@gnu.org>
2013-05-01 5:14 ` Joel Brobecker
2013-05-04 13:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430072725.GA3525@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox