From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sourceware.org
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: Wunused coff-pe-read
Date: Mon, 01 Apr 2013 13:29:00 -0000 [thread overview]
Message-ID: <51598375.70607@qnx.com> (raw)
Message-ID: <20130401132900.m9n3AysJMrhPYB0IiSanWL0KECYGSETh1isiajkTijE@z> (raw)
In-Reply-To: <20130329002946.GI4758@adacore.com>
On 13-03-28 08:29 PM, Joel Brobecker wrote:
>> Aleksandar Ristovski <aristovski@qnx.com>
>>
>> * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN.
>> (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN.
>> (read_pe_exported_syms): Remove unused EXPORTIX.
>> (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES,
>> EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA,
>> ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME.
>
> Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name".
> You are removing the entities themselves, so their name should not
> be capitalized. I missed that in the two other patches I just approved.
>
>
Committed with corrected capitalization of removed entities.
http://sourceware.org/ml/gdb-cvs/2013-04/msg00004.html
Thank you,
Aleksandar Ristovski
QNX Software Systems
next prev parent reply other threads:[~2013-04-01 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 4:08 Aleksandar Ristovski
2013-03-29 5:59 ` Joel Brobecker
2013-04-01 12:54 ` Aleksandar Ristovski [this message]
2013-04-01 13:29 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51598375.70607@qnx.com \
--to=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox