From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27463 invoked by alias); 1 Apr 2013 12:54:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27298 invoked by uid 89); 1 Apr 2013 12:54:20 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from na3sys009aog103.obsmtp.com (HELO na3sys009aog103.obsmtp.com) (74.125.149.71) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Apr 2013 12:54:17 +0000 Received: from mx10.qnx.com ([209.226.137.110]) (using TLSv1) by na3sys009aob103.postini.com ([74.125.148.12]) with SMTP ID DSNKUVmDd+mePhyrcx7HMDEwlDcfo9olMDO5@postini.com; Mon, 01 Apr 2013 05:54:17 PDT Received: by mx10.qnx.com (Postfix, from userid 500) id A238B20E46; Mon, 1 Apr 2013 08:54:14 -0400 (EDT) Received: from exhts.ott.qnx.com (exch1 [10.222.2.137]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx10.qnx.com (Postfix) with ESMTPS id 872A7208F9; Mon, 1 Apr 2013 08:54:14 -0400 (EDT) Received: from [10.222.96.215] (10.222.2.5) by EXCH1.ott.qnx.com (10.222.2.137) with Microsoft SMTP Server id 14.2.318.4; Mon, 1 Apr 2013 08:54:14 -0400 Message-ID: <51598375.70607@qnx.com> Date: Mon, 01 Apr 2013 12:54:00 -0000 From: Aleksandar Ristovski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 Newsgroups: gmane.comp.gdb.patches To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [patch] cleanup: Wunused coff-pe-read References: <5109EE44.5020605@qnx.com> <20130329002946.GI4758@adacore.com> In-Reply-To: <20130329002946.GI4758@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00008.txt.bz2 On 13-03-28 08:29 PM, Joel Brobecker wrote: >> Aleksandar Ristovski >> >> * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN. >> (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN. >> (read_pe_exported_syms): Remove unused EXPORTIX. >> (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES, >> EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA, >> ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME. > > Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name". > You are removing the entities themselves, so their name should not > be capitalized. I missed that in the two other patches I just approved. > > Committed with corrected capitalization of removed entities. http://sourceware.org/ml/gdb-cvs/2013-04/msg00004.html Thank you, Aleksandar Ristovski QNX Software Systems From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27963 invoked by alias); 1 Apr 2013 12:54:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27454 invoked by uid 89); 1 Apr 2013 12:54:29 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FSL_HELO_BARE_IP_2,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_NUMERIC_HELO,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Apr 2013 12:54:27 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UMeG7-0004Pf-8R for gdb-patches@sourceware.org; Mon, 01 Apr 2013 14:54:47 +0200 Received: from 209.226.137.106 ([209.226.137.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Apr 2013 14:54:47 +0200 Received: from aristovski by 209.226.137.106 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Apr 2013 14:54:47 +0200 To: gdb-patches@sourceware.org From: Aleksandar Ristovski Subject: Re: [patch] cleanup: Wunused coff-pe-read Date: Mon, 01 Apr 2013 13:29:00 -0000 Message-ID: <51598375.70607@qnx.com> References: <5109EE44.5020605@qnx.com> <20130329002946.GI4758@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "gdb-patches@sourceware.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 In-Reply-To: <20130329002946.GI4758@adacore.com> X-SW-Source: 2013-04/txt/msg00009.txt.bz2 Message-ID: <20130401132900.m9n3AysJMrhPYB0IiSanWL0KECYGSETh1isiajkTijE@z> On 13-03-28 08:29 PM, Joel Brobecker wrote: >> Aleksandar Ristovski >> >> * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN. >> (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN. >> (read_pe_exported_syms): Remove unused EXPORTIX. >> (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES, >> EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA, >> ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME. > > Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name". > You are removing the entities themselves, so their name should not > be capitalized. I missed that in the two other patches I just approved. > > Committed with corrected capitalization of removed entities. http://sourceware.org/ml/gdb-cvs/2013-04/msg00004.html Thank you, Aleksandar Ristovski QNX Software Systems