From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"Himpel, Christian" <christian.himpel@intel.com>
Subject: Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests
Date: Fri, 08 Mar 2013 13:33:00 -0000 [thread overview]
Message-ID: <20130308133303.GA15712@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307B9D00F@IRSMSX102.ger.corp.intel.com>
On Fri, 08 Mar 2013 14:27:44 +0100, Metzger, Markus T wrote:
> > > + /* loop is declared in x86-instruction_history.S */
> >
> > /* loop is defined in 'instruction_history.S'. */
>
> I got the feedback in a review of the earlier btrace tests that x86-specific
> assembly files need to be prefixed with either x86-, ia32-, or amd64- depending
> on the architecture for which they are intended.
OK but the file is already renamed in the patch. BTW the ChangeLog is not
updated for the rename:
* gdb.btrace/x86-instruction_history.S: New file.
->
* gdb.btrace/instruction_history.S: New file.
I won't argue against another maintainer opinion, follow either way you
prefer. Just the code comment should contain the name actually used in the
patch.
Thanks,
Jan
next prev parent reply other threads:[~2013-03-08 13:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 9:19 [patch v10 00/21] branch tracing for Atom Markus Metzger
2013-03-08 9:16 ` [patch v10 07/21] btrace, doc: document remote serial protocol Markus Metzger
2013-03-08 9:17 ` [patch v10 21/21] btrace: fix crash when losing the remote connection on process exit Markus Metzger
2013-03-08 13:58 ` Jan Kratochvil
2013-03-08 14:18 ` Metzger, Markus T
2013-03-08 9:17 ` [patch v10 16/21] record: add "record function-call-history" command Markus Metzger
2013-03-08 9:17 ` [patch v10 01/21] thread, btrace: add generic branch trace support Markus Metzger
2013-03-08 9:17 ` [patch v10 09/21] target: add add_deprecated_target_alias Markus Metzger
2013-03-08 9:17 ` [patch v10 06/21] remote, gdbserver: add btrace support Markus Metzger
2013-03-08 9:17 ` [patch v10 14/21] record: default target methods Markus Metzger
2013-03-08 9:17 ` [patch v10 08/21] btrace, x86: disable on some processors Markus Metzger
2013-03-08 9:17 ` [patch v10 04/21] xml, btrace: define btrace xml document style Markus Metzger
2013-03-08 9:18 ` [patch v10 11/21] record: make it build again Markus Metzger
2013-03-08 9:18 ` [patch v10 20/21] testsuite, gdb.btrace: add btrace tests Markus Metzger
2013-03-08 13:22 ` Jan Kratochvil
2013-03-08 13:28 ` Metzger, Markus T
2013-03-08 13:33 ` Jan Kratochvil [this message]
2013-03-08 9:18 ` [patch v10 02/21] linux, btrace: perf_event based branch tracing Markus Metzger
2013-03-08 9:19 ` [patch v10 10/21] record: split record Markus Metzger
2013-03-08 9:19 ` [patch v10 03/21] linux, i386, amd64: enable btrace for 32bit and 64bit linux native Markus Metzger
2013-03-08 9:19 ` [patch v10 15/21] record: add "record instruction-history" command Markus Metzger
2013-03-08 9:19 ` [patch v10 18/21] record-btrace, disas: omit pc prefix Markus Metzger
2013-03-08 9:19 ` [patch v10 17/21] record, btrace: add record-btrace target Markus Metzger
2013-03-08 9:19 ` [patch v10 05/21] gdbserver: preserve error message in handle_qXfer Markus Metzger
2013-03-08 12:01 ` Jan Kratochvil
2013-03-08 9:19 ` [patch v10 12/21] record-full.c: rename record_ in record_full_ Markus Metzger
2013-03-08 9:19 ` [patch v10 19/21] doc, record: document record changes Markus Metzger
2013-03-08 9:19 ` [patch v10 13/21] record-full.h: rename record_ into record_full_ Markus Metzger
2013-03-08 12:16 ` [patch v10 00/21] branch tracing for Atom Jan Kratochvil
2013-03-08 12:32 ` Metzger, Markus T
2013-03-08 14:00 ` Jan Kratochvil
2013-03-08 14:58 ` Jan Kratochvil
2013-03-08 15:13 ` Metzger, Markus T
2013-03-08 15:42 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308133303.GA15712@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=christian.himpel@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox