From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22735 invoked by alias); 8 Mar 2013 13:33:23 -0000 Received: (qmail 22662 invoked by uid 22791); 8 Mar 2013 13:33:21 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 13:33:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28DX7er032330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Mar 2013 08:33:08 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28DX3ap014036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Mar 2013 08:33:06 -0500 Date: Fri, 08 Mar 2013 13:33:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "Himpel, Christian" Subject: Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests Message-ID: <20130308133303.GA15712@host2.jankratochvil.net> References: <1362734168-1725-1-git-send-email-markus.t.metzger@intel.com> <1362734168-1725-21-git-send-email-markus.t.metzger@intel.com> <20130308132146.GA12958@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00362.txt.bz2 On Fri, 08 Mar 2013 14:27:44 +0100, Metzger, Markus T wrote: > > > + /* loop is declared in x86-instruction_history.S */ > > > > /* loop is defined in 'instruction_history.S'. */ > > I got the feedback in a review of the earlier btrace tests that x86-specific > assembly files need to be prefixed with either x86-, ia32-, or amd64- depending > on the architecture for which they are intended. OK but the file is already renamed in the patch. BTW the ChangeLog is not updated for the rename: * gdb.btrace/x86-instruction_history.S: New file. -> * gdb.btrace/instruction_history.S: New file. I won't argue against another maintainer opinion, follow either way you prefer. Just the code comment should contain the name actually used in the patch. Thanks, Jan