Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Fri, 08 Mar 2013 10:16:07 +0100, Markus Metzger wrote:
> From: Christian Himpel <christian.himpel@intel.com>
> 
> Recursive function calls are listed as only one function call.  This is
> marked as a KFAIL with PR gdb/15420.
typo:                           15240
But it is OK in the sources.


> The discussed crash of gdbserver after continue with btrace target
> enabled is tested now as well in the end of the enable.exp.  In case of
> a gdbserver crash it reports UNRESOLVED, is that appropriate?

PASS: gdb.btrace/enable.exp: record btrace re-enable twice
ERROR: Process no longer exists
UNRESOLVED: gdb.btrace/enable.exp: continue to end

OK.


> gdb/testsuite
> 	* Makefile.in: Add btrace testsuite.
> 	* configure: Regenerated.
> 	* configure.ac: Add btrace testsuite.
> 	* gdb.btrace/Makefile.in: New file.
> 	* gdb.btrace/enable.c: New file.
> 	* gdb.btrace/enable.exp: New file.
> 	* gdb.btrace/function_call_history.c: New file.
> 	* gdb.btrace/function_call_history.exp: New file.
> 	* gdb.btrace/instruction_history.c: New file.
> 	* gdb.btrace/instruction_history.exp: New file.
> 	* gdb.btrace/x86-instruction_history.S: New file.
> 	* lib/gdb.exp: Add btrace skip proc.

OK with the bit below.


> --- /dev/null
> +++ b/gdb/testsuite/gdb.btrace/instruction_history.c
> @@ -0,0 +1,26 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> +   Copyright 2013 Free Software Foundation, Inc.
> +
> +   Contributed by Intel Corp. <christian.himpel@intel.com>
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +int
> +main (void)
> +{
> +  /* loop is declared in x86-instruction_history.S */

/* loop is defined in 'instruction_history.S'.  */



> +  loop ();
> +  return 0;
> +}


Thanks,
Jan