Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 20 Feb 2013 16:56:04 +0100, Pedro Alves wrote:
> However, one unwritten rule (not just GDB's) that applies more broadly
> than configure things is to not overengineer things, do the minimal
> necessary, and worry only about unknown problems if they turn
> out to be real problems.

In such case we could use gdb_assert / internal_error everywhere.
This was what I was submitting before as any GDB problems get then
automatically bugreported with context via ABRT, probably also Apport etc.
I was told on gdb-patches warning calls are preferred in such case instead as
it does not break the user's debugging session.

OTOH here you ask for the opposite, unchecked inclusion of include file which
is very complicated with compiler-dependent parts and arch-specific code,
which all seem to me to possibly cause compilation failures.

So there should be either the way of (1) fatal error in the case of troubles
or (2) ignore (warn only) any troubles.

I do not see a clear direction of (1) or (2), initially I tried to go (1) and
now I try to go (2) but neither seems OK for you.


Jan