From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Pedro Alves <palves@redhat.com>,
Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx
Date: Mon, 25 Feb 2013 14:19:00 -0000 [thread overview]
Message-ID: <20130225141902.GA25286@host2.jankratochvil.net> (raw)
In-Reply-To: <m2621mn3n8.fsf@igel.home>
On Wed, 20 Feb 2013 21:15:07 +0100, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> > + /* Below we'll mmap a non-executable page, which under Valgrind
> > + results in annoying warnings such as
> > + "Bad permissions for mapped region at address 0xfoobar".
> > + Just skip the whole test if running under Valgrind. */
> > +#ifdef HAVE_RUNNING_ON_VALGRIND
> > + if (RUNNING_ON_VALGRIND)
> > + return;
> > +#endif
>
> Wouldn't it be enough for gdb to ship with an appropriate suppression
> file?
Besides some inconveniences of using suppression files primarily there would
still remain the false warning printed by GDB itself:
warning: linux_ptrace_test_ret_to_nx: PC 0x3806e309 is neither near return address 0x4032000 nor is the return instruction 0x602e33!
Jan
next prev parent reply other threads:[~2013-02-25 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 18:42 [patch] " Jan Kratochvil
2013-02-19 19:11 ` Pedro Alves
2013-02-20 14:06 ` Jan Kratochvil
2013-02-20 15:06 ` Pedro Alves
2013-02-20 15:24 ` [patch+NEWS] " Jan Kratochvil
2013-02-20 15:56 ` Pedro Alves
2013-02-20 16:08 ` Jan Kratochvil
2013-02-20 17:30 ` Pedro Alves
2013-02-25 14:33 ` Jan Kratochvil
2013-02-25 18:10 ` Pedro Alves
2013-02-26 3:00 ` Jan Kratochvil
2013-02-20 20:15 ` Andreas Schwab
2013-02-25 14:19 ` Jan Kratochvil [this message]
2013-02-19 21:09 ` [patch] " Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225141902.GA25286@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=philippe.waroquiers@skynet.be \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox