From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23980 invoked by alias); 20 Feb 2013 16:08:30 -0000 Received: (qmail 23940 invoked by uid 22791); 20 Feb 2013 16:08:28 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Feb 2013 16:08:15 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1KG8DId011421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 20 Feb 2013 11:08:13 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1KG89D9005346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 20 Feb 2013 11:08:11 -0500 Date: Wed, 20 Feb 2013 16:08:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx Message-ID: <20130220160808.GA19181@host2.jankratochvil.net> References: <20130220140520.GA10822@host2.jankratochvil.net> <5124E66D.3060606@redhat.com> <20130220152331.GA16617@host2.jankratochvil.net> <5124F214.7020506@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5124F214.7020506@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00536.txt.bz2 On Wed, 20 Feb 2013 16:56:04 +0100, Pedro Alves wrote: > However, one unwritten rule (not just GDB's) that applies more broadly > than configure things is to not overengineer things, do the minimal > necessary, and worry only about unknown problems if they turn > out to be real problems. In such case we could use gdb_assert / internal_error everywhere. This was what I was submitting before as any GDB problems get then automatically bugreported with context via ABRT, probably also Apport etc. I was told on gdb-patches warning calls are preferred in such case instead as it does not break the user's debugging session. OTOH here you ask for the opposite, unchecked inclusion of include file which is very complicated with compiler-dependent parts and arch-specific code, which all seem to me to possibly cause compilation failures. So there should be either the way of (1) fatal error in the case of troubles or (2) ignore (warn only) any troubles. I do not see a clear direction of (1) or (2), initially I tried to go (1) and now I try to go (2) but neither seems OK for you. Jan