From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'.
Date: Thu, 14 Feb 2013 18:30:00 -0000 [thread overview]
Message-ID: <201302141830.r1EIU16S003105@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20130214171404.2223.83713.stgit@brno.lan> (message from Pedro Alves on Thu, 14 Feb 2013 17:14:04 +0000)
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 Feb 2013 17:14:04 +0000
>
> It's better to avoid needless confusion, and call a string's length,
> length, instead of size, which is usually used to refer to sizeof of
> the string (len+1):
>
> size_t len = strlen (str);
> size_t size = sizeof (str);
>
> Tested on x86_64 Fedora 17.
Agreed
> 2013-02-14 Pedro Alves <palves@redhat.com>
>
> * utils.c (savestring): Rename parameter 'size' to 'len'.
> ---
> gdb/utils.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
prev parent reply other threads:[~2013-02-14 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 17:14 Pedro Alves
2013-02-14 17:14 ` [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it Pedro Alves
2013-02-14 18:07 ` Tom Tromey
2013-02-14 18:08 ` Pedro Alves
2013-02-14 18:10 ` Tom Tromey
2013-02-14 18:14 ` Pedro Alves
2013-02-14 18:24 ` Tom Tromey
2013-02-14 18:31 ` Pedro Alves
2013-02-14 18:54 ` Joel Brobecker
2013-02-14 20:35 ` Tom Tromey
2013-02-14 21:05 ` Joel Brobecker
2013-02-21 21:15 ` Tom Tromey
2013-02-14 18:30 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302141830.r1EIU16S003105@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox