From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23445 invoked by alias); 14 Feb 2013 18:30:19 -0000 Received: (qmail 23431 invoked by uid 22791); 14 Feb 2013 18:30:16 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 18:30:12 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r1EIU2t4007400; Thu, 14 Feb 2013 19:30:02 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r1EIU16S003105; Thu, 14 Feb 2013 19:30:01 +0100 (CET) Date: Thu, 14 Feb 2013 18:30:00 -0000 Message-Id: <201302141830.r1EIU16S003105@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: palves@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <20130214171404.2223.83713.stgit@brno.lan> (message from Pedro Alves on Thu, 14 Feb 2013 17:14:04 +0000) Subject: Re: [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'. References: <20130214171404.2223.83713.stgit@brno.lan> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00369.txt.bz2 > From: Pedro Alves > Date: Thu, 14 Feb 2013 17:14:04 +0000 > > It's better to avoid needless confusion, and call a string's length, > length, instead of size, which is usually used to refer to sizeof of > the string (len+1): > > size_t len = strlen (str); > size_t size = sizeof (str); > > Tested on x86_64 Fedora 17. Agreed > 2013-02-14 Pedro Alves > > * utils.c (savestring): Rename parameter 'size' to 'len'. > --- > gdb/utils.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >