From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
Date: Thu, 14 Feb 2013 18:24:00 -0000 [thread overview]
Message-ID: <87ehgiiwjb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <511D2980.10703@redhat.com> (Pedro Alves's message of "Thu, 14 Feb 2013 18:14:24 +0000")
Pedro> Yeah... It'd be an easier sell if libiberty wasn't such a
Pedro> kitchen sink. I know that parts of libiberty would be problematic
Pedro> for the Windows CE (I know, it's rotten by now), not sure about
Pedro> other ports.
I suppose my main concern here is that the gdb/gdbserver unification
project will end up needing to reimplement chunks of libiberty.
But that would be a bad result, since libiberty already exists.
I don't really care so much about this particular function.
It is small, it doesn't really matter. The xstrndup name is better
(IMO), but unimportantly so.
Tom
next prev parent reply other threads:[~2013-02-14 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 17:14 [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len' Pedro Alves
2013-02-14 17:14 ` [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it Pedro Alves
2013-02-14 18:07 ` Tom Tromey
2013-02-14 18:08 ` Pedro Alves
2013-02-14 18:10 ` Tom Tromey
2013-02-14 18:14 ` Pedro Alves
2013-02-14 18:24 ` Tom Tromey [this message]
2013-02-14 18:31 ` Pedro Alves
2013-02-14 18:54 ` Joel Brobecker
2013-02-14 20:35 ` Tom Tromey
2013-02-14 21:05 ` Joel Brobecker
2013-02-21 21:15 ` Tom Tromey
2013-02-14 18:30 ` [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len' Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehgiiwjb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox