[PATCH] Garbage collect deprecated_pc_in_call_dummy

[PATCH] Garbage collect deprecated_pc_in_call_dummy

[Pedro Alves]

I noticed there are no users of deprecated_pc_in_call_dummy left in
the tree.

The last user was ARM.  Usage removed here:

http://sourceware.org/ml/gdb-patches/2010-03/msg00820.html

This deletes the function.

Applied.

2013-02-01  Pedro Alves  <palves@redhat.com>

	* dummy-frame.c (deprecated_pc_in_call_dummy): Delete function.
	* frame.h (deprecated_pc_in_call_dummy): Delete declaration.
---
 gdb/dummy-frame.c |   34 ----------------------------------
 gdb/frame.h       |    2 --
 2 files changed, 36 deletions(-)

diff --git a/gdb/dummy-frame.c b/gdb/dummy-frame.c
index 12310f8..390a6d8 100644
--- a/gdb/dummy-frame.c
+++ b/gdb/dummy-frame.c
@@ -47,40 +47,6 @@ struct dummy_frame
 
 static struct dummy_frame *dummy_frame_stack = NULL;
 
-/* Function: deprecated_pc_in_call_dummy (pc)
-
-   Return non-zero if the PC falls in a dummy frame created by gdb for
-   an inferior call.  The code below which allows gdbarch_decr_pc_after_break
-   is for infrun.c, which may give the function a PC without that
-   subtracted out.
-
-   FIXME: cagney/2002-11-23: This is silly.  Surely "infrun.c" can
-   figure out what the real PC (as in the resume address) is BEFORE
-   calling this function.
-
-   NOTE: cagney/2004-08-02: I'm pretty sure that, with the introduction of
-   infrun.c:adjust_pc_after_break (thanks), this function is now
-   always called with a correctly adjusted PC!
-
-   NOTE: cagney/2004-08-02: Code should not need to call this.  */
-
-int
-deprecated_pc_in_call_dummy (struct gdbarch *gdbarch, CORE_ADDR pc)
-{
-  struct dummy_frame *dummyframe;
-
-  for (dummyframe = dummy_frame_stack;
-       dummyframe != NULL;
-       dummyframe = dummyframe->next)
-    {
-      if ((pc >= dummyframe->id.code_addr)
-	  && (pc <= dummyframe->id.code_addr
-		    + gdbarch_decr_pc_after_break (gdbarch)))
-	return 1;
-    }
-  return 0;
-}
-
 /* Push the caller's state, along with the dummy frame info, onto the
    dummy-frame stack.  */
 
diff --git a/gdb/frame.h b/gdb/frame.h
index e3c6d91..31b9cb7 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -670,8 +670,6 @@ extern void print_frame_info (struct frame_info *, int print_level,
 
 extern struct frame_info *block_innermost_frame (const struct block *);
 
-extern int deprecated_pc_in_call_dummy (struct gdbarch *gdbarch, CORE_ADDR pc);
-
 extern int deprecated_frame_register_read (struct frame_info *frame, int regnum,
 				gdb_byte *buf);
 

Re: [PATCH] Garbage collect deprecated_pc_in_call_dummy

[Mark Kettenis]

> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 01 Feb 2013 19:59:09 +0000
> 
> I noticed there are no users of deprecated_pc_in_call_dummy left in
> the tree.
> 
> The last user was ARM.  Usage removed here:
> 
> http://sourceware.org/ml/gdb-patches/2010-03/msg00820.html
> 
> This deletes the function.
> 
> Applied.

Yay!