From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Garbage collect deprecated_pc_in_call_dummy
Date: Fri, 01 Feb 2013 19:59:00 -0000 [thread overview]
Message-ID: <20130201195909.27717.68593.stgit@brno.lan> (raw)
I noticed there are no users of deprecated_pc_in_call_dummy left in
the tree.
The last user was ARM. Usage removed here:
http://sourceware.org/ml/gdb-patches/2010-03/msg00820.html
This deletes the function.
Applied.
2013-02-01 Pedro Alves <palves@redhat.com>
* dummy-frame.c (deprecated_pc_in_call_dummy): Delete function.
* frame.h (deprecated_pc_in_call_dummy): Delete declaration.
---
gdb/dummy-frame.c | 34 ----------------------------------
gdb/frame.h | 2 --
2 files changed, 36 deletions(-)
diff --git a/gdb/dummy-frame.c b/gdb/dummy-frame.c
index 12310f8..390a6d8 100644
--- a/gdb/dummy-frame.c
+++ b/gdb/dummy-frame.c
@@ -47,40 +47,6 @@ struct dummy_frame
static struct dummy_frame *dummy_frame_stack = NULL;
-/* Function: deprecated_pc_in_call_dummy (pc)
-
- Return non-zero if the PC falls in a dummy frame created by gdb for
- an inferior call. The code below which allows gdbarch_decr_pc_after_break
- is for infrun.c, which may give the function a PC without that
- subtracted out.
-
- FIXME: cagney/2002-11-23: This is silly. Surely "infrun.c" can
- figure out what the real PC (as in the resume address) is BEFORE
- calling this function.
-
- NOTE: cagney/2004-08-02: I'm pretty sure that, with the introduction of
- infrun.c:adjust_pc_after_break (thanks), this function is now
- always called with a correctly adjusted PC!
-
- NOTE: cagney/2004-08-02: Code should not need to call this. */
-
-int
-deprecated_pc_in_call_dummy (struct gdbarch *gdbarch, CORE_ADDR pc)
-{
- struct dummy_frame *dummyframe;
-
- for (dummyframe = dummy_frame_stack;
- dummyframe != NULL;
- dummyframe = dummyframe->next)
- {
- if ((pc >= dummyframe->id.code_addr)
- && (pc <= dummyframe->id.code_addr
- + gdbarch_decr_pc_after_break (gdbarch)))
- return 1;
- }
- return 0;
-}
-
/* Push the caller's state, along with the dummy frame info, onto the
dummy-frame stack. */
diff --git a/gdb/frame.h b/gdb/frame.h
index e3c6d91..31b9cb7 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -670,8 +670,6 @@ extern void print_frame_info (struct frame_info *, int print_level,
extern struct frame_info *block_innermost_frame (const struct block *);
-extern int deprecated_pc_in_call_dummy (struct gdbarch *gdbarch, CORE_ADDR pc);
-
extern int deprecated_frame_register_read (struct frame_info *frame, int regnum,
gdb_byte *buf);
next reply other threads:[~2013-02-01 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 19:59 Pedro Alves [this message]
2013-02-01 20:13 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201195909.27717.68593.stgit@brno.lan \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox