Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
	Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] Add CTF support to GDB [5] Add test for CTF function
Date: Mon, 14 Jan 2013 13:30:00 -0000	[thread overview]
Message-ID: <20130114073252.GQ6143@adacore.com> (raw)
In-Reply-To: <CANFwon2=EmBWtGqx5ygrmMNt0MBM0oLbjOZ2VMsx5+S9TErP7w@mail.gmail.com>

This isn't a review, but I noticed that...

> --- /dev/null
> +++ b/testsuite/gdb.trace/ctf.c
> @@ -0,0 +1,33 @@
> +typedef char test_t1;

... this file is missing a copyright header.

Thank you,
-- 
Joel


      parent reply	other threads:[~2013-01-14 13:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14  3:49 Hui Zhu
2013-01-14 12:44 ` Yao Qi
2013-01-15 11:19   ` Hui Zhu
2013-01-15 13:49     ` Yao Qi
2013-01-16  7:39       ` Hui Zhu
2013-01-16  9:52         ` Yao Qi
2013-01-18  1:23           ` Hui Zhu
2013-01-18  2:07             ` Yao Qi
2013-01-18 15:28             ` Tom Tromey
2013-01-25 11:10               ` Hui Zhu
2013-02-11 12:55                 ` Hui Zhu
2013-02-18 10:39                 ` Yao Qi
2013-02-19  6:57                   ` Hui Zhu
2013-01-14 13:30 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114073252.GQ6143@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox