Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit 1/3] minor ravenscar-thread cleanup
Date: Sat, 15 Dec 2012 14:49:00 -0000	[thread overview]
Message-ID: <20121215144919.GG3654@adacore.com> (raw)
In-Reply-To: <50CB5BA8.3030902@redhat.com>

> I question the pushing of this target from the inferior_created observer.
> Detecting the ravenscar runtime is based on looking for some symbols,
> so it would seem to me that doing that from a new_objfile observer
> (which is what e.g., linux-thread-db.c, another thread_stratum target,
> does) would be more correct (e.g., it'd work to attach to a target,
> notice missing symbols, and point GDB at symbols, at which point GDB
> would load a new objfile and detect ravenscar).

You are probably right, I need to look into it. I want to get rid
of some of the globals - I will look into all of this at the same
time.

Note that the patch itself does not change anything at the moment,
it just inlines one function into the observer code.

-- 
Joel


      reply	other threads:[~2012-12-15 14:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14 15:02 Joel Brobecker
2012-12-14 15:03 ` [RFA 2/3] gdbarch-ification of ravenscar-thread support Joel Brobecker
2012-12-14 17:17   ` Pedro Alves
2012-12-15 14:47     ` Joel Brobecker
2012-12-14 15:03 ` [RFA 3/3] Add ravenscar-thread support for powerpc Joel Brobecker
2012-12-14 17:34   ` Pedro Alves
2012-12-14 17:03 ` [RFA/commit 1/3] minor ravenscar-thread cleanup Pedro Alves
2012-12-15 14:49   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121215144919.GG3654@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox