Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/3] gdbarch-ification of ravenscar-thread support.
Date: Sat, 15 Dec 2012 14:47:00 -0000	[thread overview]
Message-ID: <20121215144630.GF3654@adacore.com> (raw)
In-Reply-To: <50CB5F33.2030402@redhat.com>

> > The question: Right now, I put ravenscar-thread.o in the list of
> > objects to always be built, regardless of whether or not GDB is
> > configured with a target that can take advantage of it.  I seems
> > slightly wasteful, but somehow consistent with have solib-target
> > always available, for instance.
> 
> It's a little bit different, because solib-target is driven entirely
> from data the target pushes to GDB.  Any random embedded target can
> enable that with no changes to GDB.  Ravenscar support always
> needs code changes in GDB, OTOH.

Agreed. I made the changes, and ravenscar-thread.o is only pulled in
when another arch-specific ravenscar-thread unit is included.

> BTW, ARCH-ravenscar-thread.c would be a naming scheme more in line
> with other files.  Can we change that before adding more ports?

No problem. I agree as well.

I did it by adding a few extra patches on top of this one. That way,
it allows me to provide patches that show the intent of the changes
along them way... This is now a 6-patches series!

Thanks for the feedback,
-- 
Joel


  reply	other threads:[~2012-12-15 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14 15:02 [RFA/commit 1/3] minor ravenscar-thread cleanup Joel Brobecker
2012-12-14 15:03 ` [RFA 2/3] gdbarch-ification of ravenscar-thread support Joel Brobecker
2012-12-14 17:17   ` Pedro Alves
2012-12-15 14:47     ` Joel Brobecker [this message]
2012-12-14 15:03 ` [RFA 3/3] Add ravenscar-thread support for powerpc Joel Brobecker
2012-12-14 17:34   ` Pedro Alves
2012-12-14 17:03 ` [RFA/commit 1/3] minor ravenscar-thread cleanup Pedro Alves
2012-12-15 14:49   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121215144630.GF3654@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox