From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29227 invoked by alias); 15 Dec 2012 14:49:36 -0000 Received: (qmail 29217 invoked by uid 22791); 15 Dec 2012 14:49:34 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Dec 2012 14:49:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CA5C22E2CD; Sat, 15 Dec 2012 09:49:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 03TPjXuWQ90R; Sat, 15 Dec 2012 09:49:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 62F3A2E2C9; Sat, 15 Dec 2012 09:49:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9319EC14DD; Sat, 15 Dec 2012 18:49:19 +0400 (RET) Date: Sat, 15 Dec 2012 14:49:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit 1/3] minor ravenscar-thread cleanup Message-ID: <20121215144919.GG3654@adacore.com> References: <1355497356-13922-1-git-send-email-brobecker@adacore.com> <50CB5BA8.3030902@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50CB5BA8.3030902@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00527.txt.bz2 > I question the pushing of this target from the inferior_created observer. > Detecting the ravenscar runtime is based on looking for some symbols, > so it would seem to me that doing that from a new_objfile observer > (which is what e.g., linux-thread-db.c, another thread_stratum target, > does) would be more correct (e.g., it'd work to attach to a target, > notice missing symbols, and point GDB at symbols, at which point GDB > would load a new objfile and detect ravenscar). You are probably right, I need to look into it. I want to get rid of some of the globals - I will look into all of this at the same time. Note that the patch itself does not change anything at the moment, it just inlines one function into the observer code. -- Joel