Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Misc annotations changes.
Date: Wed, 21 Nov 2012 20:14:00 -0000	[thread overview]
Message-ID: <20121121201416.1015.36832.stgit@brno.lan> (raw)
In-Reply-To: <50ACF672.7060607@redhat.com>

On 11/21/2012 03:42 PM, Pedro Alves wrote:
> The reason I'm looking at annotation code is that I made a change
> that puts software single-step breakpoints in the regular breakpoint
> chain, and then that triggers breakpoints-invalid annotations for
> each sss breakpoint that didn't happen before, and in turn that
> leads to the gdb.log getting filled up with useless notifications
> and the tests timing out.  I had a small patch to handle this, but it turns
> out incomplete.  Further looking at this issue, I've decided to go ahead
> and fully convert the breakpoints-invalid annotation to observers.

And there are the changes.  The changes are sort of independent, but
the each builds on the previous.  This order was chosen to avoid
introducing failures in the tree at each stage.

I've tested this on X86_64 Fedora 17, and smoke tested it with emacs
24.1.1 in gud-gdb mode.

Let me know if you see an issue with this.

---

Pedro Alves (4):
      Remove (alledged) "breakpoints-changed" annotation suppression on ignore count changes.
      Suppress repeated annotations until GDB is ready to accept input.
      Fully move the breakpoints-invalid annotation to observers.
      Skip breakpoints-invalid annotations for internal|momentary breakpoints.


 gdb/annotate.c                     |   61 ++++++++++++++++++------------------
 gdb/annotate.h                     |    5 +--
 gdb/breakpoint.c                   |   11 +-----
 gdb/event-top.c                    |    3 ++
 gdb/testsuite/gdb.base/annota1.exp |   22 ++++++++-----
 gdb/testsuite/gdb.cp/annota2.exp   |   13 +++++---
 6 files changed, 57 insertions(+), 58 deletions(-)

-- 
Pedro Alves


       reply	other threads:[~2012-11-21 20:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50ACF672.7060607@redhat.com>
2012-11-21 20:14 ` Pedro Alves [this message]
2012-11-21 20:14   ` [PATCH 3/4] Fully move the breakpoints-invalid annotation to observers Pedro Alves
2012-11-26 15:23     ` Tom Tromey
2012-11-21 20:14   ` [PATCH 4/4] Skip breakpoints-invalid annotations for internal|momentary breakpoints Pedro Alves
2012-11-21 20:14   ` [PATCH 2/4] Suppress repeated annotations until GDB is ready to accept input Pedro Alves
2012-11-26 15:50     ` Tom Tromey
2012-11-26 18:28       ` Pedro Alves
2012-11-27 18:48         ` Tom Tromey
2012-11-27 23:53           ` Pedro Alves
2013-01-22 19:59           ` Pedro Alves
2012-11-27 18:56         ` Eli Zaretskii
2012-11-21 20:14   ` [PATCH 1/4] Remove (alleged) "breakpoints-changed" annotation suppression on ignore count changes Pedro Alves
2012-11-26 15:42   ` [PATCH 0/4] Misc annotations changes Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121201416.1015.36832.stgit@brno.lan \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox