From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6746 invoked by alias); 21 Nov 2012 20:14:26 -0000 Received: (qmail 6737 invoked by uid 22791); 21 Nov 2012 20:14:23 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 20:14:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qALKEHfO025894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Nov 2012 15:14:17 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qALKEGXN032516 for ; Wed, 21 Nov 2012 15:14:17 -0500 Subject: [PATCH 0/4] Misc annotations changes. To: gdb-patches@sourceware.org From: Pedro Alves Date: Wed, 21 Nov 2012 20:14:00 -0000 Message-ID: <20121121201416.1015.36832.stgit@brno.lan> In-Reply-To: <50ACF672.7060607@redhat.com> References: <50ACF672.7060607@redhat.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00585.txt.bz2 On 11/21/2012 03:42 PM, Pedro Alves wrote: > The reason I'm looking at annotation code is that I made a change > that puts software single-step breakpoints in the regular breakpoint > chain, and then that triggers breakpoints-invalid annotations for > each sss breakpoint that didn't happen before, and in turn that > leads to the gdb.log getting filled up with useless notifications > and the tests timing out. I had a small patch to handle this, but it turns > out incomplete. Further looking at this issue, I've decided to go ahead > and fully convert the breakpoints-invalid annotation to observers. And there are the changes. The changes are sort of independent, but the each builds on the previous. This order was chosen to avoid introducing failures in the tree at each stage. I've tested this on X86_64 Fedora 17, and smoke tested it with emacs 24.1.1 in gud-gdb mode. Let me know if you see an issue with this. --- Pedro Alves (4): Remove (alledged) "breakpoints-changed" annotation suppression on ignore count changes. Suppress repeated annotations until GDB is ready to accept input. Fully move the breakpoints-invalid annotation to observers. Skip breakpoints-invalid annotations for internal|momentary breakpoints. gdb/annotate.c | 61 ++++++++++++++++++------------------ gdb/annotate.h | 5 +-- gdb/breakpoint.c | 11 +----- gdb/event-top.c | 3 ++ gdb/testsuite/gdb.base/annota1.exp | 22 ++++++++----- gdb/testsuite/gdb.cp/annota2.exp | 13 +++++--- 6 files changed, 57 insertions(+), 58 deletions(-) -- Pedro Alves