Re: [PATCH 2/4] Suppress repeated annotations until GDB is ready to accept input.

[Tom Tromey <tromey@redhat.com>]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Hmm.  There's potential for making it worse.  The patch
Pedro> suppresses duplicate annotations until the next prompt is
Pedro> displayed.  With background commands, events can be reported
Pedro> without re-displaying a prompt [*].  In that case, emacs might
Pedro> miss annotations.

FWIW, I am not sure this is so very bad.
Async is still an advanced user thing.
And, if Emacs gets out of sync it is simple to do "up;down" or the like
to get back in sync.

Pedro> With this version, we don't do annotation suppression if a background
Pedro> command is in progress.  This means that

Pedro>  define twobreaks
Pedro> b foo
Pedro> b bar
Pedro> end
Pedro>  twobreaks

Pedro> triggers two annotations in async mode if the target is not
Pedro> running, or isn't running the foreground, while always just one
Pedro> in sync mode.  I don't think that's a real problem.

Me neither.  It isn't even clear Emacs does anything with those
annotations at all.

Pedro> [*] - though that could itself be considered a bug, the CLI
Pedro> output is less than ideal here.  We should be able to keep the
Pedro> bottom line reserved for the prompt, and scroll the rest of the
Pedro> output without visually interfering with the prompt line.  E.g.,
Pedro> we could be able to unwind the cursor to column 0, print whatever
Pedro> while handling the event, and then redisplay the prompt as it
Pedro> was, without the user noticing.  Or perhaps there's cleaner ways
Pedro> even.

Do you mean, do this in Emacs or for the CLI itself?
Either way I think it would be nice.  I've often wished we could replace
the "Reading..." messages, which are often illegible, with some kind of
nicer hash progress meter thing ...

Pedro> Is there any way to force emacs 24 to do full annotations?  It actually
Pedro> hadn't realized that "--fullname" was annotate=1, not 2, so my previous
Pedro> emacs testing was useless, as these notifications only happen with
Pedro> annotate=2...

I don't think there is.  When I tried just editing the gdb command line
I ended up with a lot of "^Z^Z" in the gud buffer.  I guess you could
dig up Emacs 23 (still in F16...) or try to downgrade the gud code.

Tom