Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH: Check is_amd64_regs_target to to set nr_regs
@ 2012-10-11 15:25 H.J. Lu
  2012-10-11 17:16 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2012-10-11 15:25 UTC (permalink / raw)
  To: GDB

Hi,

We should check is_amd64_regs_target instead of is_ilp32_target to set
nr_regs.  X32 is a amd64_regs target as well as ilp32 target.  OK to
install?

Thanks.

H.J.
---
2012-10-11  H.J. Lu  <hongjiu.lu@intel.com>

	* gdb.arch/i386-avx.exp: Check is_amd64_regs_target instead of
	is_ilp32_target to set nr_regs.
	* gdb.arch/i386-sse.exp: Likewise.

diff --git a/gdb/testsuite/gdb.arch/i386-avx.exp b/gdb/testsuite/gdb.arch/i386-avx.exp
index 52a6e4a..32ba5b6 100644
--- a/gdb/testsuite/gdb.arch/i386-avx.exp
+++ b/gdb/testsuite/gdb.arch/i386-avx.exp
@@ -73,10 +73,10 @@ gdb_test "break [gdb_get_line_number "first breakpoint here"]" \
          "set first breakpoint in main"
 gdb_continue_to_breakpoint "continue to first breakpoint in main"
 
-if [is_ilp32_target] {
-    set nr_regs 8
-} else {
+if [is_amd64_regs_target] {
     set nr_regs 16
+} else {
+    set nr_regs 8
 }
 
 for { set r 0 } { $r < $nr_regs } { incr r } {
diff --git a/gdb/testsuite/gdb.arch/i386-sse.exp b/gdb/testsuite/gdb.arch/i386-sse.exp
index 896faf3..4132e0c 100644
--- a/gdb/testsuite/gdb.arch/i386-sse.exp
+++ b/gdb/testsuite/gdb.arch/i386-sse.exp
@@ -73,10 +73,10 @@ gdb_test "break [gdb_get_line_number "first breakpoint here"]" \
          "set first breakpoint in main"
 gdb_continue_to_breakpoint "continue to first breakpoint in main"
 
-if [is_ilp32_target] {
-    set nr_regs 8
-} else {
+if [is_amd64_regs_target] {
     set nr_regs 16
+} else {
+    set nr_regs 8
 }
 
 for { set r 0 } { $r < $nr_regs } { incr r } {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Check is_amd64_regs_target to to set nr_regs
  2012-10-11 15:25 PATCH: Check is_amd64_regs_target to to set nr_regs H.J. Lu
@ 2012-10-11 17:16 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2012-10-11 17:16 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GDB

On 10/11/2012 04:24 PM, H.J. Lu wrote:

> 2012-10-11  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* gdb.arch/i386-avx.exp: Check is_amd64_regs_target instead of
> 	is_ilp32_target to set nr_regs.
> 	* gdb.arch/i386-sse.exp: Likewise.

OK.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-11 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-11 15:25 PATCH: Check is_amd64_regs_target to to set nr_regs H.J. Lu
2012-10-11 17:16 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox