From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23436 invoked by alias); 11 Oct 2012 15:25:08 -0000 Received: (qmail 23403 invoked by uid 22791); 11 Oct 2012 15:25:07 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ie0-f169.google.com (HELO mail-ie0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 15:25:01 +0000 Received: by mail-ie0-f169.google.com with SMTP id 10so4037388ied.0 for ; Thu, 11 Oct 2012 08:25:00 -0700 (PDT) Received: by 10.50.153.162 with SMTP id vh2mr1148011igb.67.1349969100818; Thu, 11 Oct 2012 08:25:00 -0700 (PDT) Received: from gnu-tools-1.localdomain (76-220-57-190.lightspeed.sntcca.sbcglobal.net. [76.220.57.190]) by mx.google.com with ESMTPS id uj11sm9293806igb.15.2012.10.11.08.24.58 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 11 Oct 2012 08:24:59 -0700 (PDT) Received: by gnu-tools-1.localdomain (Postfix, from userid 1000) id 72DAA1A0649; Thu, 11 Oct 2012 08:24:56 -0700 (PDT) Date: Thu, 11 Oct 2012 15:25:00 -0000 From: "H.J. Lu" To: GDB Subject: PATCH: Check is_amd64_regs_target to to set nr_regs Message-ID: <20121011152456.GA14479@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00173.txt.bz2 Hi, We should check is_amd64_regs_target instead of is_ilp32_target to set nr_regs. X32 is a amd64_regs target as well as ilp32 target. OK to install? Thanks. H.J. --- 2012-10-11 H.J. Lu * gdb.arch/i386-avx.exp: Check is_amd64_regs_target instead of is_ilp32_target to set nr_regs. * gdb.arch/i386-sse.exp: Likewise. diff --git a/gdb/testsuite/gdb.arch/i386-avx.exp b/gdb/testsuite/gdb.arch/i386-avx.exp index 52a6e4a..32ba5b6 100644 --- a/gdb/testsuite/gdb.arch/i386-avx.exp +++ b/gdb/testsuite/gdb.arch/i386-avx.exp @@ -73,10 +73,10 @@ gdb_test "break [gdb_get_line_number "first breakpoint here"]" \ "set first breakpoint in main" gdb_continue_to_breakpoint "continue to first breakpoint in main" -if [is_ilp32_target] { - set nr_regs 8 -} else { +if [is_amd64_regs_target] { set nr_regs 16 +} else { + set nr_regs 8 } for { set r 0 } { $r < $nr_regs } { incr r } { diff --git a/gdb/testsuite/gdb.arch/i386-sse.exp b/gdb/testsuite/gdb.arch/i386-sse.exp index 896faf3..4132e0c 100644 --- a/gdb/testsuite/gdb.arch/i386-sse.exp +++ b/gdb/testsuite/gdb.arch/i386-sse.exp @@ -73,10 +73,10 @@ gdb_test "break [gdb_get_line_number "first breakpoint here"]" \ "set first breakpoint in main" gdb_continue_to_breakpoint "continue to first breakpoint in main" -if [is_ilp32_target] { - set nr_regs 8 -} else { +if [is_amd64_regs_target] { set nr_regs 16 +} else { + set nr_regs 8 } for { set r 0 } { $r < $nr_regs } { incr r } {