[PATCH] Expand size of LEN parameter for invalidate_bp_value_on_memory_change

[PATCH] Expand size of LEN parameter for invalidate_bp_value_on_memory_change

[Siddhesh Poyarekar]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi,

Attached patch expands the LEN parameter of
invalidate_bp_value_on_memory_change to ssize_t to reflect the LEN that
is actually sent by write_memory_with_notification.  I have updated
observer.texi accordingly so that the observer function signatures are
correct (as well as the generated documentation).  No regressions
resulting from this change on x86_64.  OK to commit?

Regards,
Siddhesh

gdb/ChangeLog:

	* breakpoint.c (invalidate_bp_value_on_memory_change): Expand
	parameter LEN to ssize_t.

doc/ChangeLog:

	observer.texi (memory_changed): Expand parameter LEN to ssize_t.

[-- Attachment #2: observer.patch --]
[-- Type: text/x-patch, Size: 1315 bytes --]

? array-size.patch
? observer.patch
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.705
diff -u -r1.705 breakpoint.c
--- gdb/breakpoint.c	25 Sep 2012 12:48:52 -0000	1.705
+++ gdb/breakpoint.c	25 Sep 2012 14:01:00 -0000
@@ -14718,7 +14718,7 @@
    GDB itself.  */
 
 static void
-invalidate_bp_value_on_memory_change (CORE_ADDR addr, int len,
+invalidate_bp_value_on_memory_change (CORE_ADDR addr, ssize_t len,
 				      const bfd_byte *data)
 {
   struct breakpoint *bp;
Index: gdb/doc/observer.texi
===================================================================
RCS file: /cvs/src/src/gdb/doc/observer.texi,v
retrieving revision 1.40
diff -u -r1.40 observer.texi
--- gdb/doc/observer.texi	21 Sep 2012 01:46:43 -0000	1.40
+++ gdb/doc/observer.texi	25 Sep 2012 14:01:00 -0000
@@ -230,7 +230,7 @@
 This method is called immediately before freeing @var{inf}.
 @end deftypefun
 
-@deftypefun void memory_changed (CORE_ADDR @var{addr}, int @var{len}, const bfd_byte *@var{data})
+@deftypefun void memory_changed (CORE_ADDR @var{addr}, ssize_t @var{len}, const bfd_byte *@var{data})
 Bytes from @var{data} to @var{data} + @var{len} have been written
 to the current inferior at @var{addr}.
 @end deftypefun

Re: [PATCH] Expand size of LEN parameter for invalidate_bp_value_on_memory_change

[Tom Tromey]

>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:

Siddhesh> Attached patch expands the LEN parameter of
Siddhesh> invalidate_bp_value_on_memory_change to ssize_t to reflect the
Siddhesh> LEN that is actually sent by write_memory_with_notification.
Siddhesh> I have updated observer.texi accordingly so that the observer
Siddhesh> function signatures are correct (as well as the generated
Siddhesh> documentation).  No regressions resulting from this change on
Siddhesh> x86_64.  OK to commit?

Ok.  Thanks for doing this.

Tom