Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Expand size of LEN parameter for invalidate_bp_value_on_memory_change
Date: Tue, 25 Sep 2012 14:02:00 -0000	[thread overview]
Message-ID: <20120925193119.2cd0dd75@spoyarek> (raw)

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi,

Attached patch expands the LEN parameter of
invalidate_bp_value_on_memory_change to ssize_t to reflect the LEN that
is actually sent by write_memory_with_notification.  I have updated
observer.texi accordingly so that the observer function signatures are
correct (as well as the generated documentation).  No regressions
resulting from this change on x86_64.  OK to commit?

Regards,
Siddhesh

gdb/ChangeLog:

	* breakpoint.c (invalidate_bp_value_on_memory_change): Expand
	parameter LEN to ssize_t.

doc/ChangeLog:

	observer.texi (memory_changed): Expand parameter LEN to ssize_t.

[-- Attachment #2: observer.patch --]
[-- Type: text/x-patch, Size: 1315 bytes --]

? array-size.patch
? observer.patch
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.705
diff -u -r1.705 breakpoint.c
--- gdb/breakpoint.c	25 Sep 2012 12:48:52 -0000	1.705
+++ gdb/breakpoint.c	25 Sep 2012 14:01:00 -0000
@@ -14718,7 +14718,7 @@
    GDB itself.  */
 
 static void
-invalidate_bp_value_on_memory_change (CORE_ADDR addr, int len,
+invalidate_bp_value_on_memory_change (CORE_ADDR addr, ssize_t len,
 				      const bfd_byte *data)
 {
   struct breakpoint *bp;
Index: gdb/doc/observer.texi
===================================================================
RCS file: /cvs/src/src/gdb/doc/observer.texi,v
retrieving revision 1.40
diff -u -r1.40 observer.texi
--- gdb/doc/observer.texi	21 Sep 2012 01:46:43 -0000	1.40
+++ gdb/doc/observer.texi	25 Sep 2012 14:01:00 -0000
@@ -230,7 +230,7 @@
 This method is called immediately before freeing @var{inf}.
 @end deftypefun
 
-@deftypefun void memory_changed (CORE_ADDR @var{addr}, int @var{len}, const bfd_byte *@var{data})
+@deftypefun void memory_changed (CORE_ADDR @var{addr}, ssize_t @var{len}, const bfd_byte *@var{data})
 Bytes from @var{data} to @var{data} + @var{len} have been written
 to the current inferior at @var{addr}.
 @end deftypefun

             reply	other threads:[~2012-09-25 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 14:02 Siddhesh Poyarekar [this message]
2012-09-25 20:48 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925193119.2cd0dd75@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox