Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
Date: Tue, 25 Sep 2012 12:51:00 -0000	[thread overview]
Message-ID: <20120925182011.082b668b@spoyarek> (raw)
In-Reply-To: <20120925082558.GA9305@host2.jankratochvil.net>

On Tue, 25 Sep 2012 10:25:58 +0200, Jan wrote:
> 		ax_const_l (ax, TYPE_LENGTH (value.type));
> 
> 
> (You even did so in s390_value_from_register as I see.)
> 

Yeah, keeping it in there would have changed the program flow.
 
> 
> I see no bugs there, OK for check-in with those few changes.
> 

Committed with your suggested changes:

http://sourceware.org/ml/gdb-cvs/2012-09/msg00142.html

Thanks,
Siddhesh


  reply	other threads:[~2012-09-25 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 12:06 Siddhesh Poyarekar
2012-09-25  8:26 ` Jan Kratochvil
2012-09-25 12:51   ` Siddhesh Poyarekar [this message]
2012-09-25 20:28   ` Tom Tromey
2012-09-25 20:37     ` Jan Kratochvil
2012-09-25 20:49       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925182011.082b668b@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox