From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94824-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22270 invoked by alias); 25 Sep 2012 12:51:07 -0000
Received: (qmail 22262 invoked by uid 22791); 25 Sep 2012 12:51:06 -0000
X-SWARE-Spam-Status: No, hits=-8.1 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Sep 2012 12:50:53 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PCorm5030757	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 25 Sep 2012 08:50:53 -0400
Received: from spoyarek (spoyarek.pnq.redhat.com [10.65.192.188])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8PCop4T008962;	Tue, 25 Sep 2012 08:50:52 -0400
Date: Tue, 25 Sep 2012 12:51:00 -0000
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
Message-ID: <20120925182011.082b668b@spoyarek>
In-Reply-To: <20120925082558.GA9305@host2.jankratochvil.net>
References: <20120924173542.625d322c@spoyarek>	<20120925082558.GA9305@host2.jankratochvil.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00547.txt.bz2

On Tue, 25 Sep 2012 10:25:58 +0200, Jan wrote:
> 		ax_const_l (ax, TYPE_LENGTH (value.type));
> 
> 
> (You even did so in s390_value_from_register as I see.)
> 

Yeah, keeping it in there would have changed the program flow.
 
> 
> I see no bugs there, OK for check-in with those few changes.
> 

Committed with your suggested changes:

http://sourceware.org/ml/gdb-cvs/2012-09/msg00142.html

Thanks,
Siddhesh