Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
Date: Tue, 25 Sep 2012 20:37:00 -0000	[thread overview]
Message-ID: <20120925203704.GA29051@host2.jankratochvil.net> (raw)
In-Reply-To: <87fw6526gv.fsf@fleche.redhat.com>

On Tue, 25 Sep 2012 22:27:44 +0200, Tom Tromey wrote:
> Jan> While correct I find this expression too tricky, check_typedef should be
> Jan> called rather ahead of some block of code later depending on it.
> 
> I often think we should have TYPE_LENGTH call check_typedef invisibly.
> The current situation seems error-prone.

It can be very expensive, one should benchmark it.  Also in some situations
during DWARF reading it may not be safe to call check_typedef (although
check_typedef already looks at CURRENTLY_READING_SYMTAB so it may work).

Anyway it is outside of the scope of Siddhesh's patch.


Thanks,
Jan


  reply	other threads:[~2012-09-25 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 12:06 Siddhesh Poyarekar
2012-09-25  8:26 ` Jan Kratochvil
2012-09-25 12:51   ` Siddhesh Poyarekar
2012-09-25 20:28   ` Tom Tromey
2012-09-25 20:37     ` Jan Kratochvil [this message]
2012-09-25 20:49       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925203704.GA29051@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=siddhesh@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox