Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, dje@google.com
Subject: Re: [patch+7.5] auto-load: User conveniences suggested by Doug Evans
Date: Sun, 09 Sep 2012 08:53:00 -0000	[thread overview]
Message-ID: <20120909085312.GA4994@host2.jankratochvil.net> (raw)
In-Reply-To: <838vd4gns3.fsf@gnu.org>

On Fri, 24 Aug 2012 20:14:52 +0200, Eli Zaretskii wrote:
> > > > +  scripts_directory_help = xstrprintf (_("\
> > > > +Automatically loaded %s%s%sGDB scripts\n\
> > > > +(named OBJFILE%s) are located in one of the directories listed by this\n\
> > > > +option.\n\
> > > > +This option is ignored for the kinds of scripts \
> > > > +having 'set auto-load ... off'.\n\
> > > > +Directories listed here need to be present also \
> > > > +in the 'set auto-load safe-path'\n\
> > > > +option."),
> > > 
> > > Here, the lines are unnecessarily too short, IMO.
> > 
> > I think there should be some clear decision what should the GDB output conform
> > to.  In this and the paragraph above we have exactly opposite opinions whether
> > to wrap the text or not.
> 
> The above simply looks aesthetically wrong to me.  Whatever standards
> we set, they should first and foremost be presentable.

I find the source form of the help text confusing the discussion here, let's
talk about the output only.  Formatting of the output into the source file
does not matter much I think.

--with python form:
(gdb) help set auto-load scripts-directory 
Set the list of directories from which to load auto-loaded scripts.
Automatically loaded Python scripts (named OBJFILE-gdb.py) and GDB scripts
(named OBJFILE-gdb.gdb) are located in one of the directories listed by this
option.
This option is ignored for the kinds of scripts having 'set auto-load ... off'.
Directories listed here need to be present also in the 'set auto-load safe-path'
option.

--without-python form:
(gdb) help set auto-load scripts-directory 
Set the list of directories from which to load auto-loaded scripts.
Automatically loaded GDB scripts
(named OBJFILE-gdb.gdb) are located in one of the directories listed by this
option.
This option is ignored for the kinds of scripts having 'set auto-load ... off'.
Directories listed here need to be present also in the 'set auto-load safe-path'
option.

Do you find anything aesthetically wrong with this output form and could you
suggest specific changes?

--without-python form is not perfect but I find it good enough for the less
common case of builds.


Thanks,
Jan


  reply	other threads:[~2012-09-09  8:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 14:44 Jan Kratochvil
2012-08-21 17:50 ` Eli Zaretskii
2012-08-24 16:11   ` Jan Kratochvil
2012-08-24 18:15     ` Eli Zaretskii
2012-09-09  8:53       ` Jan Kratochvil [this message]
2012-09-09 17:26         ` Eli Zaretskii
2012-09-09 17:55           ` Jan Kratochvil
2012-09-09 18:09             ` Eli Zaretskii
2012-08-22 15:46 ` Pedro Alves
2012-08-24 15:13   ` Jan Kratochvil
2012-08-24 15:17     ` Pedro Alves
2012-08-24 15:19   ` Eli Zaretskii
2012-08-24 15:28     ` Pedro Alves
2012-08-24 15:31       ` Pedro Alves
2012-08-24 15:43         ` Jan Kratochvil
2012-08-24 17:56         ` Eli Zaretskii
2012-08-24 18:01           ` Jan Kratochvil
2012-08-24 18:26             ` Eli Zaretskii
2012-08-27 18:02               ` Pedro Alves
2012-08-27 18:12                 ` Jan Kratochvil
2012-09-09  9:02                   ` Jan Kratochvil
2012-09-10 11:29                     ` Pedro Alves
2012-09-10 11:47                       ` Jan Kratochvil
2012-09-10 13:06                         ` Pedro Alves
2012-09-10 15:28                           ` Jan Kratochvil
2012-09-17 18:29                             ` [commit+7.5] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120909085312.GA4994@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox